Patchwork [03/11] Add a test case for qfloat

login
register
mail settings
Submitter Anthony Liguori
Date Oct. 17, 2009, 1:36 p.m.
Message ID <1255786571-3528-4-git-send-email-aliguori@us.ibm.com>
Download mbox | patch
Permalink /patch/36304/
State New
Headers show

Comments

Anthony Liguori - Oct. 17, 2009, 1:36 p.m.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 Makefile       |    2 +
 check-qfloat.c |   81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 configure      |    2 +-
 3 files changed, 84 insertions(+), 1 deletions(-)
 create mode 100644 check-qfloat.c
Edgar Iglesias - Oct. 17, 2009, 2 p.m.
On Sat, Oct 17, 2009 at 08:36:03AM -0500, Anthony Liguori wrote:
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  Makefile       |    2 +
>  check-qfloat.c |   81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++


Hello Anthony,

Shouldn't we put these tests under tests/something/ ?

Cheers


>  configure      |    2 +-
>  3 files changed, 84 insertions(+), 1 deletions(-)
>  create mode 100644 check-qfloat.c
> 
> diff --git a/Makefile b/Makefile
> index 9294638..aedb6c7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -216,6 +216,8 @@ check-qint: check-qint.o qint.o qemu-malloc.o
>  check-qstring: check-qstring.o qstring.o qemu-malloc.o
>  check-qdict: check-qdict.o qdict.o qint.o qstring.o qemu-malloc.o
>  check-qlist: check-qlist.o qlist.o qint.o qemu-malloc.o
> +check-qfloat: check-qfloat.o qfloat.o qemu-malloc.o
> +
>  
>  clean:
>  # avoid old build problems by removing potentially incorrect old files
> diff --git a/check-qfloat.c b/check-qfloat.c
> new file mode 100644
> index 0000000..3758700
> --- /dev/null
> +++ b/check-qfloat.c
> @@ -0,0 +1,81 @@
> +/*
> + * QFloat unit-tests.
> + *
> + * Copyright (C) 2009 Red Hat Inc.
> + *
> + * Authors:
> + *  Luiz Capitulino <lcapitulino@redhat.com>
> + *
> + * Copyright IBM, Corp. 2009
> + *
> + * Authors:
> + *  Anthony Liguori   <aliguori@us.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
> + * See the COPYING.LIB file in the top-level directory.
> + *
> + */
> +#include <check.h>
> +
> +#include "qfloat.h"
> +#include "qemu-common.h"
> +
> +/*
> + * Public Interface test-cases
> + *
> + * (with some violations to access 'private' data)
> + */
> +
> +START_TEST(qfloat_from_double_test)
> +{
> +    QFloat *qf;
> +    const double value = -42.23423;
> +
> +    qf = qfloat_from_double(value);
> +    fail_unless(qf != NULL);
> +    fail_unless(qf->value == value);
> +    fail_unless(qf->base.refcnt == 1);
> +    fail_unless(qobject_type(QOBJECT(qf)) == QTYPE_QFLOAT);
> +
> +    // destroy doesn't exit yet
> +    qemu_free(qf);
> +}
> +END_TEST
> +
> +START_TEST(qfloat_destroy_test)
> +{
> +    QFloat *qf = qfloat_from_double(0.0);
> +    QDECREF(qf);
> +}
> +END_TEST
> +
> +static Suite *qfloat_suite(void)
> +{
> +    Suite *s;
> +    TCase *qfloat_public_tcase;
> +
> +    s = suite_create("QFloat test-suite");
> +
> +    qfloat_public_tcase = tcase_create("Public Interface");
> +    suite_add_tcase(s, qfloat_public_tcase);
> +    tcase_add_test(qfloat_public_tcase, qfloat_from_double_test);
> +    tcase_add_test(qfloat_public_tcase, qfloat_destroy_test);
> +
> +    return s;
> +}
> +
> +int main(void)
> +{
> +    int nf;
> +    Suite *s;
> +    SRunner *sr;
> +
> +    s = qfloat_suite();
> +    sr = srunner_create(s);
> +
> +    srunner_run_all(sr, CK_NORMAL);
> +    nf = srunner_ntests_failed(sr);
> +    srunner_free(sr);
> +
> +    return (nf == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
> +}
> diff --git a/configure b/configure
> index ca6d45c..3e6f980 100755
> --- a/configure
> +++ b/configure
> @@ -2024,7 +2024,7 @@ if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then
>    if [ "$linux" = "yes" ] ; then
>        tools="qemu-nbd\$(EXESUF) qemu-io\$(EXESUF) $tools"
>      if [ "$check_utests" = "yes" ]; then
> -      tools="check-qint check-qstring check-qdict check-qlist $tools"
> +      tools="check-qint check-qstring check-qdict check-qlist check-qfloat $tools"
>      fi
>    elif test "$mingw32" = "yes" ; then
>        tools="qemu-io\$(EXESUF) $tools"
> -- 
> 1.6.2.5
> 
> 
>
Anthony Liguori - Oct. 17, 2009, 4:21 p.m.
Edgar E. Iglesias wrote:
> On Sat, Oct 17, 2009 at 08:36:03AM -0500, Anthony Liguori wrote:
>   
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>> ---
>>  Makefile       |    2 +
>>  check-qfloat.c |   81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>     
>
>
> Hello Anthony,
>
> Shouldn't we put these tests under tests/something/ ?
>   

Indeed, I think that would clean up things a bit too as the 
configure/Makefile integration is a bit awkward.  I'll take a look.

Regards,

Anthony Liguori

Patch

diff --git a/Makefile b/Makefile
index 9294638..aedb6c7 100644
--- a/Makefile
+++ b/Makefile
@@ -216,6 +216,8 @@  check-qint: check-qint.o qint.o qemu-malloc.o
 check-qstring: check-qstring.o qstring.o qemu-malloc.o
 check-qdict: check-qdict.o qdict.o qint.o qstring.o qemu-malloc.o
 check-qlist: check-qlist.o qlist.o qint.o qemu-malloc.o
+check-qfloat: check-qfloat.o qfloat.o qemu-malloc.o
+
 
 clean:
 # avoid old build problems by removing potentially incorrect old files
diff --git a/check-qfloat.c b/check-qfloat.c
new file mode 100644
index 0000000..3758700
--- /dev/null
+++ b/check-qfloat.c
@@ -0,0 +1,81 @@ 
+/*
+ * QFloat unit-tests.
+ *
+ * Copyright (C) 2009 Red Hat Inc.
+ *
+ * Authors:
+ *  Luiz Capitulino <lcapitulino@redhat.com>
+ *
+ * Copyright IBM, Corp. 2009
+ *
+ * Authors:
+ *  Anthony Liguori   <aliguori@us.ibm.com>
+ *
+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
+ * See the COPYING.LIB file in the top-level directory.
+ *
+ */
+#include <check.h>
+
+#include "qfloat.h"
+#include "qemu-common.h"
+
+/*
+ * Public Interface test-cases
+ *
+ * (with some violations to access 'private' data)
+ */
+
+START_TEST(qfloat_from_double_test)
+{
+    QFloat *qf;
+    const double value = -42.23423;
+
+    qf = qfloat_from_double(value);
+    fail_unless(qf != NULL);
+    fail_unless(qf->value == value);
+    fail_unless(qf->base.refcnt == 1);
+    fail_unless(qobject_type(QOBJECT(qf)) == QTYPE_QFLOAT);
+
+    // destroy doesn't exit yet
+    qemu_free(qf);
+}
+END_TEST
+
+START_TEST(qfloat_destroy_test)
+{
+    QFloat *qf = qfloat_from_double(0.0);
+    QDECREF(qf);
+}
+END_TEST
+
+static Suite *qfloat_suite(void)
+{
+    Suite *s;
+    TCase *qfloat_public_tcase;
+
+    s = suite_create("QFloat test-suite");
+
+    qfloat_public_tcase = tcase_create("Public Interface");
+    suite_add_tcase(s, qfloat_public_tcase);
+    tcase_add_test(qfloat_public_tcase, qfloat_from_double_test);
+    tcase_add_test(qfloat_public_tcase, qfloat_destroy_test);
+
+    return s;
+}
+
+int main(void)
+{
+    int nf;
+    Suite *s;
+    SRunner *sr;
+
+    s = qfloat_suite();
+    sr = srunner_create(s);
+
+    srunner_run_all(sr, CK_NORMAL);
+    nf = srunner_ntests_failed(sr);
+    srunner_free(sr);
+
+    return (nf == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
+}
diff --git a/configure b/configure
index ca6d45c..3e6f980 100755
--- a/configure
+++ b/configure
@@ -2024,7 +2024,7 @@  if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then
   if [ "$linux" = "yes" ] ; then
       tools="qemu-nbd\$(EXESUF) qemu-io\$(EXESUF) $tools"
     if [ "$check_utests" = "yes" ]; then
-      tools="check-qint check-qstring check-qdict check-qlist $tools"
+      tools="check-qint check-qstring check-qdict check-qlist check-qfloat $tools"
     fi
   elif test "$mingw32" = "yes" ; then
       tools="qemu-io\$(EXESUF) $tools"