Patchwork mtd_blkdevs.c: quiet a "symbol shadows" sparse warning

login
register
mail settings
Submitter hartleys
Date Oct. 16, 2009, 10:52 p.m.
Message ID <BD79186B4FD85F4B8E60E381CAEE190901E2455C@mi8nycmail19.Mi8.com>
Download mbox | patch
Permalink /patch/36280/
State Accepted
Commit 6f4e137e9af8745ccaddaf5dcb037a1175089e1c
Headers show

Comments

hartleys - Oct. 16, 2009, 10:52 p.m.
In register_mtd_blktrans(), the symbol 'ret' is already declared
as an int at the start of the function.  The inner loop declaration
is unnecessary.  Quiets the following sparse warning:

  warning: symbol 'ret' shadows an earlier one

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

Patch

diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 8ca17a3..b76d6e5 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -379,7 +379,7 @@  int register_mtd_blktrans(struct mtd_blktrans_ops *tr)
 	tr->blkcore_priv->thread = kthread_run(mtd_blktrans_thread, tr,
 			"%sd", tr->name);
 	if (IS_ERR(tr->blkcore_priv->thread)) {
-		int ret = PTR_ERR(tr->blkcore_priv->thread);
+		ret = PTR_ERR(tr->blkcore_priv->thread);
 		blk_cleanup_queue(tr->blkcore_priv->rq);
 		unregister_blkdev(tr->major, tr->name);
 		kfree(tr->blkcore_priv);