diff mbox

[trivial] block.c: Remove useless 'buf' variable

Message ID 53A581FC.6050305@gmail.com
State New
Headers show

Commit Message

Chen Gang June 21, 2014, 1 p.m. UTC
'buf' is not used actually, so remove it and related snprintf() statement.


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 block.c | 2 --
 dtc     | 1 -
 2 files changed, 3 deletions(-)
 delete mode 160000 dtc

Comments

Michael Tokarev June 21, 2014, 3:03 p.m. UTC | #1
21.06.2014 17:00, Chen Gang wrote:
> 'buf' is not used actually, so remove it and related snprintf() statement.

Applied to -trivial, after removing wrong reference to dtc submodule removal.
Please don't include these in diffs.

Thanks,

/mjt
Chen Gang June 22, 2014, 2:03 a.m. UTC | #2
On 06/21/2014 11:03 PM, Michael Tokarev wrote:
> 21.06.2014 17:00, Chen Gang wrote:
>> 'buf' is not used actually, so remove it and related snprintf() statement.
> 
> Applied to -trivial, after removing wrong reference to dtc submodule removal.
> Please don't include these in diffs.
> 

OK, thanks, I shall notice about it, next time.


Thanks.
Kevin Wolf June 23, 2014, 1:37 p.m. UTC | #3
Am 21.06.2014 um 15:00 hat Chen Gang geschrieben:
> 'buf' is not used actually, so remove it and related snprintf() statement.
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>
diff mbox

Patch

diff --git a/block.c b/block.c
index 43abe96..74af8d7 100644
--- a/block.c
+++ b/block.c
@@ -5595,7 +5595,6 @@  void bdrv_img_create(const char *filename, const char *fmt,
         if (backing_file) {
             BlockDriverState *bs;
             uint64_t size;
-            char buf[32];
             int back_flags;
 
             /* backing files always opened read-only */
@@ -5616,7 +5615,6 @@  void bdrv_img_create(const char *filename, const char *fmt,
             bdrv_get_geometry(bs, &size);
             size *= 512;
 
-            snprintf(buf, sizeof(buf), "%" PRId64, size);
             qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size);
 
             bdrv_unref(bs);
diff --git a/dtc b/dtc
deleted file mode 160000
index bc895d6..0000000
--- a/dtc
+++ /dev/null
@@ -1 +0,0 @@ 
-Subproject commit bc895d6d09695d05ceb8b52486ffe861d6cfbdde