Message ID | 1403249741-17014-1-git-send-email-l.majewski@samsung.com |
---|---|
State | Not Applicable |
Delegated to: | Marek Vasut |
Headers | show |
On 06/20/2014 01:35 AM, Lukasz Majewski wrote: > diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c > U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, > "TIZEN \"THOR\" downloader", > - "<USB_controller> <interface> <dev>\n" > + "<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" > " - device software upgrade via LTHOR TIZEN dowload\n" > " program via <USB_controller> on device <dev>,\n" > " attached to interface <interface>\n" I couldn't find any examples of other commands which do this. Rathe than add the "e.g." text, perhaps just add the word "thor" at the start of the command parameter list. That's much more common in existing commands: - "<USB_controller> <interface> <dev>\n" + "thor <USB_controller> <interface> <dev>\n"
Hi Stephen, > On 06/20/2014 01:35 AM, Lukasz Majewski wrote: > > > diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c > > > U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, > > "TIZEN \"THOR\" downloader", > > - "<USB_controller> <interface> <dev>\n" > > + "<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" > > " - device software upgrade via LTHOR TIZEN dowload\n" > > " program via <USB_controller> on device <dev>,\n" > > " attached to interface <interface>\n" > > I couldn't find any examples of other commands which do this. Rathe > than add the "e.g." text, perhaps just add the word "thor" at the > start of the command parameter list. That's much more common in > existing commands: > > - "<USB_controller> <interface> <dev>\n" > + "thor <USB_controller> <interface> <dev>\n" > Ok. Thanks.
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c index 8ed1dc6..25de048 100644 --- a/common/cmd_thordown.c +++ b/common/cmd_thordown.c @@ -64,7 +64,7 @@ done: U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down, "TIZEN \"THOR\" downloader", - "<USB_controller> <interface> <dev>\n" + "<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> --- common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)