diff mbox

[AARCH64] Enable fuse-caller-save for AARCH64

Message ID 53A2D6F6.5020500@mentor.com
State New
Headers show

Commit Message

Tom de Vries June 19, 2014, 12:26 p.m. UTC 
On 19-06-14 05:21, Richard Henderson wrote:
> On 06/01/2014 03:00 AM, Tom de Vries wrote:
>> +/* Emit call insn with PAT and do aarch64-specific handling.  */
>> +
>> +bool
>> +aarch64_emit_call_insn (rtx pat)
>> +{
>> +  rtx insn = emit_call_insn (pat);
>> +
>> +  rtx *fusage = &CALL_INSN_FUNCTION_USAGE (insn);
>> +  clobber_reg (fusage, gen_rtx_REG (word_mode, IP0_REGNUM));
>> +  clobber_reg (fusage, gen_rtx_REG (word_mode, IP1_REGNUM));
>> +}
>> +
>
> Which can't have been bootstrapped, since this has no return stmt.
> Why the bool return type anyway?  Nothing appears to use it.
>

Richard,

Indeed, the return type should be void, this patch fixes that.

I have no setup to bootstrap this on aarch64. I've build an aarch64 compiler and 
ran the gcc.target/aarch64/fuse-caller-save.c testcase.

Committed as obvious.

Thanks,
- Tom
diff mbox

Patch

2014-06-19  Tom de Vries  <tom@codesourcery.com>

	* config/aarch64/aarch64-protos.h (aarch64_emit_call_insn): Change
	return type to void.
	* config/aarch64/aarch64.c (aarch64_emit_call_insn): Same.

diff --git a/gcc/config/aarch64/aarch64-protos.h b/gcc/config/aarch64/aarch64-protos.h
index 213c8dc..53023ba 100644
--- a/gcc/config/aarch64/aarch64-protos.h
+++ b/gcc/config/aarch64/aarch64-protos.h
@@ -245,7 +245,7 @@  void aarch64_init_cumulative_args (CUMULATIVE_ARGS *, const_tree, rtx,
 void aarch64_init_expanders (void);
 void aarch64_print_operand (FILE *, rtx, char);
 void aarch64_print_operand_address (FILE *, rtx);
-bool aarch64_emit_call_insn (rtx);
+void aarch64_emit_call_insn (rtx);
 
 /* Initialize builtins for SIMD intrinsics.  */
 void init_aarch64_simd_builtins (void);
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index b2d005b..f0aafbd 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -3395,7 +3395,7 @@  aarch64_fixed_condition_code_regs (unsigned int *p1, unsigned int *p2)
 
 /* Emit call insn with PAT and do aarch64-specific handling.  */
 
-bool
+void
 aarch64_emit_call_insn (rtx pat)
 {
   rtx insn = emit_call_insn (pat);
-- 
1.9.1