diff mbox

block/iscsi: fix init value for iTask->retries

Message ID 1403109611-12289-1-git-send-email-pl@kamp.de
State New
Headers show

Commit Message

Peter Lieven June 18, 2014, 4:40 p.m. UTC 
during rebasing the changed init value for the
retry counter was missed. This resulted in no retries
being performed at all.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 block/iscsi.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Stefan Hajnoczi June 23, 2014, 8:06 a.m. UTC | #1 
On Wed, Jun 18, 2014 at 06:40:11PM +0200, Peter Lieven wrote:
> during rebasing the changed init value for the
> retry counter was missed. This resulted in no retries
> being performed at all.
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  block/iscsi.c |    1 -
>  1 file changed, 1 deletion(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan
Stefan Hajnoczi June 23, 2014, 8:13 a.m. UTC | #2 
On Wed, Jun 18, 2014 at 06:40:11PM +0200, Peter Lieven wrote:
> during rebasing the changed init value for the
> retry counter was missed. This resulted in no retries
> being performed at all.
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  block/iscsi.c |    1 -
>  1 file changed, 1 deletion(-)

Nevermind, Paolo already applied this via the SCSI tree.
diff mbox

Patch

diff --git a/block/iscsi.c b/block/iscsi.c
index 83c7992..327353c 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -216,7 +216,6 @@  static void iscsi_co_init_iscsitask(IscsiLun *iscsilun, struct IscsiTask *iTask)
 {
     *iTask = (struct IscsiTask) {
         .co         = qemu_coroutine_self(),
-        .retries    = ISCSI_CMD_RETRIES,
         .iscsilun   = iscsilun,
     };
 }