| Message ID | 1403091577-10232-2-git-send-email-harinik@xilinx.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Jun 18, 2014 at 1:39 PM, Harini Katakam <harinik@xilinx.com> wrote: > From: Harini Katakam <harini.katakam@xilinx.com> > > Add gpio-zynq bindings documentation. > > Signed-off-by: Harini Katakam <harinik@xilinx.com> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > --- > > v2 changes: > Improve description. (...) > +- #gpio-cells : Should be two. First cell is used to mention > + pin number. Don't call this "pin number", call it "GPIO line number". Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2014-07-07 at 04:53PM +0200, Linus Walleij wrote: > On Wed, Jun 18, 2014 at 1:39 PM, Harini Katakam <harinik@xilinx.com> wrote: > > > From: Harini Katakam <harini.katakam@xilinx.com> > > > > Add gpio-zynq bindings documentation. > > > > Signed-off-by: Harini Katakam <harinik@xilinx.com> > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > --- > > > > v2 changes: > > Improve description. > (...) > > +- #gpio-cells : Should be two. First cell is used to mention > > + pin number. > > Don't call this "pin number", call it "GPIO line number". It's also not mentioning the second cell at all. I'll take the part from gpio-msm to document this property and replace 'pin' with 'GPIO line'. Sören -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.txt b/Documentation/devicetree/bindings/gpio/gpio-zynq.txt new file mode 100644 index 0000000..b2c023a --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.txt @@ -0,0 +1,24 @@ +Xilinx Zynq GPIO controller Device Tree Bindings +------------------------------------------- + +Required properties: +- #gpio-cells : Should be two. First cell is used to mention + pin number. +- compatible : Should be "xlnx,zynq-gpio-1.0" +- clocks : Clock specifier (see clock bindings for details) +- gpio-controller : Marks the device node as a GPIO controller. +- interrupts : Interrupt specifier (see interrupt bindings for + details) +- interrupt-parent : Must be core interrupt controller +- reg : Address and length of the register set for the device + +Example: + gpio@e000a000 { + #gpio-cells = <2>; + compatible = "xlnx,zynq-gpio-1.0"; + clocks = <&clkc 42>; + gpio-controller; + interrupt-parent = <&intc>; + interrupts = <0 20 4>; + reg = <0xe000a000 0x1000>; + };