Patchwork mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present

login
register
mail settings
Submitter Roy Tam
Date Oct. 15, 2009, 2:10 p.m.
Message ID <473191350910150710o61fa2261h31808d72597946a@mail.gmail.com>
Download mbox | patch
Permalink /patch/36113/
State New
Headers show

Comments

Roy Tam - Oct. 15, 2009, 2:10 p.m.
As i8259 in mips_jazz.c is not connect to isa bus correctly, this
patch fix that.

P.S.: just click the wrong button which sent to Aurelien only. resend to list.

Signed-off-by: Roy Tam <roytam@gmail.com>


2009/10/15 Aurelien Jarno <aurelien@aurel32.net>:
> On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote:
>> As i8259 in mips_jazz.c is not connect to isa bus correctly, this
>> patch fix that.
>
> It looks fine. Could you please resend the patch with a Signed-off-by:
>
>> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
>> index 3ff367d..281713c 100644
>> --- a/hw/mips_jazz.c
>> +++ b/hw/mips_jazz.c
>> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
>>
>>      /* ISA devices */
>>      i8259 = i8259_init(env->irq[4]);
>> +    isa_bus_new(NULL);
>> +    isa_bus_irqs(i8259);
>>      DMA_init(0);
>>      pit = pit_init(0x40, i8259[0]);
>>      pcspk_init(pit);
>>
>>
>>
>
> --
> Aurelien Jarno                          GPG: 1024D/F1BCDB73
> aurelien@aurel32.net                 http://www.aurel32.net
>

Patch

diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
index 3ff367d..281713c 100644
--- a/hw/mips_jazz.c
+++ b/hw/mips_jazz.c
@@ -185,6 +185,8 @@  void mips_jazz_init (ram_addr_t ram_size,

     /* ISA devices */
     i8259 = i8259_init(env->irq[4]);
+    isa_bus_new(NULL);
+    isa_bus_irqs(i8259);
     DMA_init(0);
     pit = pit_init(0x40, i8259[0]);
     pcspk_init(pit);