| Message ID | 1255611600-18534-1-git-send-email-remi@remlab.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Rémi Denis-Courmont a écrit : > From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > --- > net/phonet/socket.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/net/phonet/socket.c b/net/phonet/socket.c > index 8c84190..0412beb 100644 > --- a/net/phonet/socket.c > +++ b/net/phonet/socket.c > @@ -112,8 +112,10 @@ void pn_deliver_sock_broadcast(struct net *net, struct sk_buff *skb) > continue; > > clone = skb_clone(skb, GFP_ATOMIC); > - if (clone) > + if (clone) { > + sock_hold(sknode); > sk_receive_skb(sknode, clone, 0); > + } > } > spin_unlock(&pnsocks.lock); > } Indeed sk_receive_skb() does a sock_put(sk) Acked-by: Eric Dumazet <eric.dumazet@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Rémi Denis-Courmont <remi@remlab.net> Date: Thu, 15 Oct 2009 16:00:00 +0300 > From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/phonet/socket.c b/net/phonet/socket.c index 8c84190..0412beb 100644 --- a/net/phonet/socket.c +++ b/net/phonet/socket.c @@ -112,8 +112,10 @@ void pn_deliver_sock_broadcast(struct net *net, struct sk_buff *skb) continue; clone = skb_clone(skb, GFP_ATOMIC); - if (clone) + if (clone) { + sock_hold(sknode); sk_receive_skb(sknode, clone, 0); + } } spin_unlock(&pnsocks.lock); }