diff mbox

[rs6000] Remove XFAIL from default_format_denormal_2.f90 for PowerPC on Linux

Message ID 1403033565.3788.11.camel@gnopaine
State New
Headers show

Commit Message

Bill Schmidt June 17, 2014, 7:32 p.m. UTC 
Hi,

The testcase gfortran.dg/default_format_denormal_2.f90 has been
reporting XPASS since 4.8 on the powerpc*-unknown-linux-gnu platforms.
This patch removes the XFAIL for powerpc*-*-linux-* from the test.  I
believe this pattern doesn't match any other platforms, but please let
me know if I should replace it with a more specific pattern instead.

Verified on powerpc64-unknown-linux-gnu (-m32 and -m64) and
powerpc64le-unknown-linux-gnu (-m64).  Is this ok for trunk, 4.9, and
4.8?

Thanks,
Bill


2014-06-17  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	* gfortran.dg/default_format_denormal_2.f90:  Remove xfail for
	powerpc*-*-linux*.

Comments

Rainer Orth June 17, 2014, 8:48 p.m. UTC | #1 
"William J. Schmidt" <wschmidt@linux.vnet.ibm.com> writes:

> Index: gcc/testsuite/gfortran.dg/default_format_denormal_2.f90
> ===================================================================
> --- gcc/testsuite/gfortran.dg/default_format_denormal_2.f90	(revision 211741)
> +++ gcc/testsuite/gfortran.dg/default_format_denormal_2.f90	(working copy)
> @@ -1,5 +1,5 @@
>  ! { dg-require-effective-target fortran_large_real }
> -! { dg-do run { xfail powerpc*-apple-darwin* powerpc*-*-linux* } }
> +! { dg-do run { xfail powerpc*-apple-darwin* } }
>  ! Test XFAILed on these platforms because the system's printf() lacks
>  ! proper support for denormalized long doubles. See PR24685

You should also update the comment: `these platforms' no longer applies.

	Rainer
David Edelsohn June 18, 2014, 1:51 p.m. UTC | #2 
On Tue, Jun 17, 2014 at 4:48 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> "William J. Schmidt" <wschmidt@linux.vnet.ibm.com> writes:
>
>> Index: gcc/testsuite/gfortran.dg/default_format_denormal_2.f90
>> ===================================================================
>> --- gcc/testsuite/gfortran.dg/default_format_denormal_2.f90   (revision 211741)
>> +++ gcc/testsuite/gfortran.dg/default_format_denormal_2.f90   (working copy)
>> @@ -1,5 +1,5 @@
>>  ! { dg-require-effective-target fortran_large_real }
>> -! { dg-do run { xfail powerpc*-apple-darwin* powerpc*-*-linux* } }
>> +! { dg-do run { xfail powerpc*-apple-darwin* } }
>>  ! Test XFAILed on these platforms because the system's printf() lacks
>>  ! proper support for denormalized long doubles. See PR24685
>
> You should also update the comment: `these platforms' no longer applies.
>
>         Rainer

Yes, okay, with the grammar fix also.

Thanks, David
diff mbox

Patch

Index: gcc/testsuite/gfortran.dg/default_format_denormal_2.f90
===================================================================
--- gcc/testsuite/gfortran.dg/default_format_denormal_2.f90	(revision 211741)
+++ gcc/testsuite/gfortran.dg/default_format_denormal_2.f90	(working copy)
@@ -1,5 +1,5 @@ 
 ! { dg-require-effective-target fortran_large_real }
-! { dg-do run { xfail powerpc*-apple-darwin* powerpc*-*-linux* } }
+! { dg-do run { xfail powerpc*-apple-darwin* } }
 ! Test XFAILed on these platforms because the system's printf() lacks
 ! proper support for denormalized long doubles. See PR24685
 !