diff mbox

[04/24] powerpc: check/return actual error on sysfs functions

Message ID 53A0512D.1090909@oracle.com (mailing list archive)
State Rejected
Headers show

Commit Message

jeff.liu June 17, 2014, 2:31 p.m. UTC 
From: Jie Liu <jeff.liu@oracle.com>

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
 arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
 arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

gregkh@linuxfoundation.org June 17, 2014, 7:23 p.m. UTC | #1 
On Tue, Jun 17, 2014 at 10:31:09PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
> 
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
>  arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
>  arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Ben and Paul, please do not take this patch, it is incorrect.

greg k-h
Benjamin Herrenschmidt June 24, 2014, 2:34 a.m. UTC | #2 
On Tue, 2014-06-17 at 12:23 -0700, Greg KH wrote:
> On Tue, Jun 17, 2014 at 10:31:09PM +0800, Jeff Liu wrote:
> > From: Jie Liu <jeff.liu@oracle.com>
> > 
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> > ---
> >  arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
> >  arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Ben and Paul, please do not take this patch, it is incorrect.

Thanks, ignored :-)

Cheers,
Ben.
diff mbox

Patch

diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c
index 788a197..e718baf 100644
--- a/arch/powerpc/platforms/powernv/opal-dump.c
+++ b/arch/powerpc/platforms/powernv/opal-dump.c
@@ -424,7 +424,7 @@  void __init opal_platform_dump_init(void)
 	int rc;
 
 	dump_kset = kset_create_and_add("dump", NULL, opal_kobj);
-	if (!dump_kset) {
+	if (IS_ERR(dump_kset)) {
 		pr_warn("%s: Failed to create dump kset\n", __func__);
 		return;
 	}
diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
index 10268c4..09c1f6f 100644
--- a/arch/powerpc/platforms/powernv/opal-elog.c
+++ b/arch/powerpc/platforms/powernv/opal-elog.c
@@ -296,9 +296,9 @@  int __init opal_elog_init(void)
 	int rc = 0;
 
 	elog_kset = kset_create_and_add("elog", NULL, opal_kobj);
-	if (!elog_kset) {
+	if (IS_ERR(elog_kset)) {
 		pr_warn("%s: failed to create elog kset\n", __func__);
-		return -1;
+		return PTR_ERR(elog_kset);
 	}
 
 	rc = opal_notifier_register(&elog_nb);