| Message ID | 1402995979-32394-10-git-send-email-ajaykumar.rs@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hi Ajay, On 17 June 2014 03:06, Ajay Kumar <ajaykumar.rs@samsung.com> wrote: > Enable drivers for FIMD, DP and parade bridge chip. > > Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> > --- > include/configs/peach-pit.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/configs/peach-pit.h b/include/configs/peach-pit.h > index 76b8d7a..88c093f 100644 > --- a/include/configs/peach-pit.h > +++ b/include/configs/peach-pit.h > @@ -22,4 +22,14 @@ > #define CONFIG_SYS_PROMPT "Peach # " > #define CONFIG_IDENT_STRING " for Peach" > > +#define CONFIG_VIDEO_PARADE > + > +/* Display */ > +#define CONFIG_LCD > +#ifdef CONFIG_LCD > +#define CONFIG_EXYNOS_FB > +#define CONFIG_EXYNOS_DP > +#define LCD_BPP LCD_COLOR16 > +#endif > + > #endif /* __CONFIG_PEACH_PIT_H */ Can this go in exynos5420.h? It seems to be common except for the PARADE bit. Regards, Simon
Simon, On Fri, Jun 20, 2014 at 9:08 AM, Simon Glass <sjg@chromium.org> wrote: > Hi Ajay, > > On 17 June 2014 03:06, Ajay Kumar <ajaykumar.rs@samsung.com> wrote: >> Enable drivers for FIMD, DP and parade bridge chip. >> >> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> >> --- >> include/configs/peach-pit.h | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/include/configs/peach-pit.h b/include/configs/peach-pit.h >> index 76b8d7a..88c093f 100644 >> --- a/include/configs/peach-pit.h >> +++ b/include/configs/peach-pit.h >> @@ -22,4 +22,14 @@ >> #define CONFIG_SYS_PROMPT "Peach # " >> #define CONFIG_IDENT_STRING " for Peach" >> >> +#define CONFIG_VIDEO_PARADE >> + >> +/* Display */ >> +#define CONFIG_LCD >> +#ifdef CONFIG_LCD >> +#define CONFIG_EXYNOS_FB >> +#define CONFIG_EXYNOS_DP >> +#define LCD_BPP LCD_COLOR16 >> +#endif >> + >> #endif /* __CONFIG_PEACH_PIT_H */ > > Can this go in exynos5420.h? It seems to be common except for the PARADE bit. No. This patchset enables display only for peach_pit. So, we cannot move this to exynos5420.h. Ajay > Regards, > Simon > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
Hi Ajay, On 20 June 2014 00:12, Ajay kumar <ajaynumb@gmail.com> wrote: > Simon, > > On Fri, Jun 20, 2014 at 9:08 AM, Simon Glass <sjg@chromium.org> wrote: >> Hi Ajay, >> >> On 17 June 2014 03:06, Ajay Kumar <ajaykumar.rs@samsung.com> wrote: >>> Enable drivers for FIMD, DP and parade bridge chip. >>> >>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> >>> --- >>> include/configs/peach-pit.h | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/include/configs/peach-pit.h b/include/configs/peach-pit.h >>> index 76b8d7a..88c093f 100644 >>> --- a/include/configs/peach-pit.h >>> +++ b/include/configs/peach-pit.h >>> @@ -22,4 +22,14 @@ >>> #define CONFIG_SYS_PROMPT "Peach # " >>> #define CONFIG_IDENT_STRING " for Peach" >>> >>> +#define CONFIG_VIDEO_PARADE >>> + >>> +/* Display */ >>> +#define CONFIG_LCD >>> +#ifdef CONFIG_LCD >>> +#define CONFIG_EXYNOS_FB >>> +#define CONFIG_EXYNOS_DP >>> +#define LCD_BPP LCD_COLOR16 >>> +#endif >>> + >>> #endif /* __CONFIG_PEACH_PIT_H */ >> >> Can this go in exynos5420.h? It seems to be common except for the PARADE bit. > No. This patchset enables display only for peach_pit. > So, we cannot move this to exynos5420.h. OK. At some point I would like to come up with a generic board for exynos5 and move pit/snow/spring/pi to that. But it can come later. Regards, Simon
diff --git a/include/configs/peach-pit.h b/include/configs/peach-pit.h index 76b8d7a..88c093f 100644 --- a/include/configs/peach-pit.h +++ b/include/configs/peach-pit.h @@ -22,4 +22,14 @@ #define CONFIG_SYS_PROMPT "Peach # " #define CONFIG_IDENT_STRING " for Peach" +#define CONFIG_VIDEO_PARADE + +/* Display */ +#define CONFIG_LCD +#ifdef CONFIG_LCD +#define CONFIG_EXYNOS_FB +#define CONFIG_EXYNOS_DP +#define LCD_BPP LCD_COLOR16 +#endif + #endif /* __CONFIG_PEACH_PIT_H */
Enable drivers for FIMD, DP and parade bridge chip. Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> --- include/configs/peach-pit.h | 10 ++++++++++ 1 file changed, 10 insertions(+)