Patchwork [JAUNTY,NETBOOK] Fix for Distorted recorded audio on ALC662

login
register
mail settings
Submitter Michael Frey
Date Oct. 14, 2009, 8:35 p.m.
Message ID <4AD635FC.6050802@canonical.com>
Download mbox | patch
Permalink /patch/36026/
State Accepted
Headers show

Comments

Michael Frey - Oct. 14, 2009, 8:35 p.m.
Andy Whitcroft wrote:
> On Wed, Oct 14, 2009 at 11:04:50AM -0400, Michael Frey wrote:
>   
>> Attached patch fixes bug: https://bugs.edge.launchpad.net/athens/+bug/409289
>>
>> Please apply to Jaunty Netbook branch.
>>
>> Patch was created by pshou@realtek.com from Realtek.
>>
>> Thanks,
>> Michael
>>
>>     
>
> Be good to have a description of what this patch fixes, and your signoff
> while you are at it.
>
>   
>> diff -Nru alsa-driver-1.0.20/alsa-kernel/pci/hda/patch_realtek.c alsa-driver-1.0.20-new/alsa-kernel/pci/hda/patch_realtek.c
>> --- alsa-driver-1.0.20/alsa-kernel/pci/hda/patch_realtek.c	2009-05-06 15:06:04.000000000 +0800
>> +++ alsa-driver-1.0.20-new/alsa-kernel/pci/hda/patch_realtek.c	2009-08-21 14:35:19.000000000 +0800
>>     
>
> This doens't look like a patch against the jaunty netbook tree.  Has it
> been tested?
>
>   
>> @@ -15745,6 +15745,7 @@
>>  };
>>  
>>  static struct hda_verb alc663_m51va_init_verbs[] = {
>> +	{0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>  	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>  	{0x16, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>  	{0x21, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP},
>> @@ -16409,6 +16410,8 @@
>>  
>>  static struct snd_pci_quirk alc662_cfg_tbl[] = {
>>  	SND_PCI_QUIRK(0x1019, 0x9087, "ECS", ALC662_ECS),
>> +	SND_PCI_QUIRK(0x1025, 0x022c, "Acer JM11_ML", ALC663_ASUS_H13),
>> +	SND_PCI_QUIRK(0x1025, 0x0244, "Acer JM11_ML", ALC663_ASUS_H13),
>>  	SND_PCI_QUIRK(0x1028, 0x02d6, "DELL", ALC272_DELL),
>>  	SND_PCI_QUIRK(0x1028, 0x02f4, "DELL ZM1", ALC272_DELL_ZM1),
>>  	SND_PCI_QUIRK(0x1043, 0x1000, "ASUS N50Vm", ALC663_ASUS_MODE1),
>>     
>
> I think the patch is in here twice, else something mad is happening
> here?
>
>   
>> diff -Nru alsa-driver-1.0.20/sound/pci/hda/patch_realtek.c alsa-driver-1.0.20-new/sound/pci/hda/patch_realtek.c
>> --- alsa-driver-1.0.20/sound/pci/hda/patch_realtek.c	2009-05-06 15:06:04.000000000 +0800
>> +++ alsa-driver-1.0.20-new/sound/pci/hda/patch_realtek.c	2009-08-21 14:35:19.000000000 +0800
>> @@ -15745,6 +15745,7 @@
>>  };
>>  
>>  static struct hda_verb alc663_m51va_init_verbs[] = {
>> +	{0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>  	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>  	{0x16, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>  	{0x21, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP},
>> @@ -16409,6 +16410,8 @@
>>  
>>  static struct snd_pci_quirk alc662_cfg_tbl[] = {
>>  	SND_PCI_QUIRK(0x1019, 0x9087, "ECS", ALC662_ECS),
>> +	SND_PCI_QUIRK(0x1025, 0x022c, "Acer JM11_ML", ALC663_ASUS_H13),
>> +	SND_PCI_QUIRK(0x1025, 0x0244, "Acer JM11_ML", ALC663_ASUS_H13),
>>  	SND_PCI_QUIRK(0x1028, 0x02d6, "DELL", ALC272_DELL),
>>  	SND_PCI_QUIRK(0x1028, 0x02f4, "DELL ZM1", ALC272_DELL_ZM1),
>>  	SND_PCI_QUIRK(0x1043, 0x1000, "ASUS N50Vm", ALC663_ASUS_MODE1),
>>     
>
>   
>> -- 
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>     
>
>   

Sent the wrong patch.

Please find the proper attached patch against the jaunty netbook branch.

This patch sets the verb table to set up the Mic on the 2 Acer units.
The patch was prepared by Realtek (pshou@realtek.com)

Signed-off-by: Michael Frey <michael.frey@canonical.com>

Thanks,
Michael
Tim Gardner - Oct. 15, 2009, 1:35 p.m.
Michael Frey wrote:
> 
> Andy Whitcroft wrote:
>> On Wed, Oct 14, 2009 at 11:04:50AM -0400, Michael Frey wrote:
>>   
>>> Attached patch fixes bug: https://bugs.edge.launchpad.net/athens/+bug/409289
>>>
>>> Please apply to Jaunty Netbook branch.
>>>
>>> Patch was created by pshou@realtek.com from Realtek.
>>>
>>> Thanks,
>>> Michael
>>>
>>>     
>> Be good to have a description of what this patch fixes, and your signoff
>> while you are at it.
>>
>>   
>>> diff -Nru alsa-driver-1.0.20/alsa-kernel/pci/hda/patch_realtek.c alsa-driver-1.0.20-new/alsa-kernel/pci/hda/patch_realtek.c
>>> --- alsa-driver-1.0.20/alsa-kernel/pci/hda/patch_realtek.c	2009-05-06 15:06:04.000000000 +0800
>>> +++ alsa-driver-1.0.20-new/alsa-kernel/pci/hda/patch_realtek.c	2009-08-21 14:35:19.000000000 +0800
>>>     
>> This doens't look like a patch against the jaunty netbook tree.  Has it
>> been tested?
>>
>>   
>>> @@ -15745,6 +15745,7 @@
>>>  };
>>>  
>>>  static struct hda_verb alc663_m51va_init_verbs[] = {
>>> +	{0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>>  	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>>  	{0x16, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>>  	{0x21, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP},
>>> @@ -16409,6 +16410,8 @@
>>>  
>>>  static struct snd_pci_quirk alc662_cfg_tbl[] = {
>>>  	SND_PCI_QUIRK(0x1019, 0x9087, "ECS", ALC662_ECS),
>>> +	SND_PCI_QUIRK(0x1025, 0x022c, "Acer JM11_ML", ALC663_ASUS_H13),
>>> +	SND_PCI_QUIRK(0x1025, 0x0244, "Acer JM11_ML", ALC663_ASUS_H13),
>>>  	SND_PCI_QUIRK(0x1028, 0x02d6, "DELL", ALC272_DELL),
>>>  	SND_PCI_QUIRK(0x1028, 0x02f4, "DELL ZM1", ALC272_DELL_ZM1),
>>>  	SND_PCI_QUIRK(0x1043, 0x1000, "ASUS N50Vm", ALC663_ASUS_MODE1),
>>>     
>> I think the patch is in here twice, else something mad is happening
>> here?
>>
>>   
>>> diff -Nru alsa-driver-1.0.20/sound/pci/hda/patch_realtek.c alsa-driver-1.0.20-new/sound/pci/hda/patch_realtek.c
>>> --- alsa-driver-1.0.20/sound/pci/hda/patch_realtek.c	2009-05-06 15:06:04.000000000 +0800
>>> +++ alsa-driver-1.0.20-new/sound/pci/hda/patch_realtek.c	2009-08-21 14:35:19.000000000 +0800
>>> @@ -15745,6 +15745,7 @@
>>>  };
>>>  
>>>  static struct hda_verb alc663_m51va_init_verbs[] = {
>>> +	{0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>>  	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>>  	{0x16, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
>>>  	{0x21, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP},
>>> @@ -16409,6 +16410,8 @@
>>>  
>>>  static struct snd_pci_quirk alc662_cfg_tbl[] = {
>>>  	SND_PCI_QUIRK(0x1019, 0x9087, "ECS", ALC662_ECS),
>>> +	SND_PCI_QUIRK(0x1025, 0x022c, "Acer JM11_ML", ALC663_ASUS_H13),
>>> +	SND_PCI_QUIRK(0x1025, 0x0244, "Acer JM11_ML", ALC663_ASUS_H13),
>>>  	SND_PCI_QUIRK(0x1028, 0x02d6, "DELL", ALC272_DELL),
>>>  	SND_PCI_QUIRK(0x1028, 0x02f4, "DELL ZM1", ALC272_DELL_ZM1),
>>>  	SND_PCI_QUIRK(0x1043, 0x1000, "ASUS N50Vm", ALC663_ASUS_MODE1),
>>>     
>>   
>>> -- 
>>> kernel-team mailing list
>>> kernel-team@lists.ubuntu.com
>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>>     
>>   
> 
> Sent the wrong patch.
> 
> Please find the proper attached patch against the jaunty netbook branch.
> 
> This patch sets the verb table to set up the Mic on the 2 Acer units.
> The patch was prepared by Realtek (pshou@realtek.com)
> 
> Signed-off-by: Michael Frey <michael.frey@canonical.com>
> 
> Thanks,
> Michael
> 
> 

The patch looks right, ACK.

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a4422e5..6b8edff 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -15217,6 +15217,7 @@  static struct hda_verb alc663_auto_init_verbs[] = {
 };
 
 static struct hda_verb alc663_m51va_init_verbs[] = {
+	{0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
 	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
 	{0x16, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
 	{0x21, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP},
@@ -15904,6 +15905,8 @@  static struct snd_pci_quirk alc662_cfg_tbl[] = {
 		      ALC662_3ST_6ch_DIG),
 	SND_PCI_QUIRK(0x17aa, 0x101e, "Lenovo", ALC662_LENOVO_101E),
 	SND_PCI_QUIRK(0x1019, 0x9087, "ECS", ALC662_ECS),
+	SND_PCI_QUIRK(0x1025, 0x022c, "Acer JM11_ML", ALC663_ASUS_H13),
+	SND_PCI_QUIRK(0x1025, 0x0244, "Acer JM11_ML", ALC663_ASUS_H13),
 	SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
 		      ALC662_3ST_6ch_DIG),