[v2,2/2] perl-mojolicious: new package

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/Config.in                            |  1 +
 package/perl-mojolicious/Config.in           |  6 ++++++
 package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
 3 files changed, 20 insertions(+)
 create mode 100644 package/perl-mojolicious/Config.in
 create mode 100644 package/perl-mojolicious/perl-mojolicious.mk

On 16/06/14 21:35, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/Config.in                            |  1 +
>  package/perl-mojolicious/Config.in           |  6 ++++++
>  package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
>  3 files changed, 20 insertions(+)
>  create mode 100644 package/perl-mojolicious/Config.in
>  create mode 100644 package/perl-mojolicious/perl-mojolicious.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index f43e985..5e16ffa 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -423,6 +423,7 @@ endif
>  	source "package/perl/Config.in"
>  if BR2_PACKAGE_PERL
>  menu "Perl libraries/modules"
> +source "package/perl-mojolicious/Config.in"
>  endmenu
>  endif
>  	source "package/php/Config.in"
> diff --git a/package/perl-mojolicious/Config.in b/package/perl-mojolicious/Config.in
> new file mode 100644
> index 0000000..766d109
> --- /dev/null
> +++ b/package/perl-mojolicious/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_PERL_MOJOLICIOUS
> +	bool "perl-mojolicious"
> +	help
> +	  Real-time web framework
> +
> +	  http://mojolicio.us
> diff --git a/package/perl-mojolicious/perl-mojolicious.mk b/package/perl-mojolicious/perl-mojolicious.mk
> new file mode 100644
> index 0000000..e4ced7e
> --- /dev/null
> +++ b/package/perl-mojolicious/perl-mojolicious.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# perl-mojolicious
> +#
> +################################################################################
> +
> +PERL_MOJOLICIOUS_VERSION = 5.07
> +PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
> +PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
> +PERL_MOJOLICIOUS_DEPENDENCIES = perl 

 There's still trailing whitespace here.

> +PERL_MOJOLICIOUS_LICENSE = artistic_2

 artistic_2 is not in our list of licenses, and is also not a format that we
would typically use.  We already have pv with Artistic-2.0, which is also what
is used by spdx.

 Regards,
 Arnout

> +
> +$(eval $(perl-package))
>

Dear Francois Perrad,

On Mon, 16 Jun 2014 21:35:57 +0200, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/Config.in                            |  1 +
>  package/perl-mojolicious/Config.in           |  6 ++++++
>  package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
>  3 files changed, 20 insertions(+)
>  create mode 100644 package/perl-mojolicious/Config.in
>  create mode 100644 package/perl-mojolicious/perl-mojolicious.mk

Patch applied, with a few changes, see below.

> 
> diff --git a/package/Config.in b/package/Config.in
> index f43e985..5e16ffa 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -423,6 +423,7 @@ endif
>  	source "package/perl/Config.in"
>  if BR2_PACKAGE_PERL
>  menu "Perl libraries/modules"
> +source "package/perl-mojolicious/Config.in"

We now indent by one tab all "source" invocations in package/Config.in.

> +PERL_MOJOLICIOUS_VERSION = 5.07
> +PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
> +PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
> +PERL_MOJOLICIOUS_DEPENDENCIES = perl 
> +PERL_MOJOLICIOUS_LICENSE = artistic_2

As noted by Arnout, I removed the trailing whitespace after "perl", and
I changed the license name to Artistic-2.0. If the license name
"artistic_2" was automatically generated by the scancpan script, you
might want to tune it to automatically change it to Artistic-2.0 in
this case.

Thanks,

Thomas

Francois, All,

On 2014-06-16 21:35 +0200, Francois Perrad spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
[--SNIP--]
> diff --git a/package/perl-mojolicious/perl-mojolicious.mk b/package/perl-mojolicious/perl-mojolicious.mk
> new file mode 100644
> index 0000000..e4ced7e
> --- /dev/null
> +++ b/package/perl-mojolicious/perl-mojolicious.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# perl-mojolicious
> +#
> +################################################################################
> +
> +PERL_MOJOLICIOUS_VERSION = 5.07

5.07 is no longer available. There's now 5.08, and it seems only the
latest version is ever available on CPAN. :-(

This is causing autobuild failures:
    http://autobuild.buildroot.net/results/358/358f531f2db90b9bc3b1e4e2158c68d2bf6587fc/

I'll send a patch bumping to 5.08 in a moment...

Regards,
Yann E. MORIN.

> +PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
> +PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
> +PERL_MOJOLICIOUS_DEPENDENCIES = perl 
> +PERL_MOJOLICIOUS_LICENSE = artistic_2
> +
> +$(eval $(perl-package))
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot