Patchwork [net-next] myri10ge: remove over-paranoid queue number modulus

login
register
mail settings
Submitter Brice Goglin
Date Oct. 9, 2008, 2:10 p.m.
Message ID <48EE10C5.5030609@myri.com>
Download mbox | patch
Permalink /patch/3595/
State Accepted
Delegated to: David Miller
Headers show

Comments

Brice Goglin - Oct. 9, 2008, 2:10 p.m.
No need to modulus the queue number in ->hard_start_xmit() since the
core is going to do that for you modulus ->real_num_tx_queues.

Signed-off-by: Brice Goglin <brice@myri.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 9, 2008, 9:31 p.m.
From: Brice Goglin <brice@myri.com>
Date: Thu, 09 Oct 2008 16:10:13 +0200

> No need to modulus the queue number in ->hard_start_xmit() since the
> core is going to do that for you modulus ->real_num_tx_queues.
> 
> Signed-off-by: Brice Goglin <brice@myri.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index ab7755a..8cec6f3 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -2643,8 +2643,6 @@  static int myri10ge_xmit(struct sk_buff *skb, struct net_device *dev)
 	u8 flags, odd_flag;
 
 	queue = skb_get_queue_mapping(skb);
-	queue &= (mgp->num_slices - 1);
-
 	ss = &mgp->ss[queue];
 	netdev_queue = netdev_get_tx_queue(mgp->dev, queue);
 	tx = &ss->tx;