diff mbox

[Trusty,SRU,3/3] fbdev/fb.h: silence warning with -Wsign-compare

Message ID 1402601042-15487-3-git-send-email-tim.gardner@canonical.com
State New
Headers show

Commit Message

Tim Gardner June 12, 2014, 7:24 p.m. UTC
From: Brian W Hart <hartb@linux.vnet.ibm.com>

BugLink: http://bugs.launchpad.net/bugs/1321791

Silence the warning when building with -Wsign-compare when fb.h is
included:

include/linux/fb.h: In function ‘__fb_pad_aligned_buffer’:
include/linux/fb.h:650:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (j = 0; j < s_pitch; j++)
                 ^

Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
(cherry picked from commit ee3468739ed83d862dbbd90397aff5258f8f2c8e)
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 include/linux/fb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Brad Figg June 12, 2014, 7:35 p.m. UTC | #1
On 06/12/2014 12:24 PM, Tim Gardner wrote:
> From: Brian W Hart <hartb@linux.vnet.ibm.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1321791
> 
> Silence the warning when building with -Wsign-compare when fb.h is
> included:
> 
> include/linux/fb.h: In function ‘__fb_pad_aligned_buffer’:
> include/linux/fb.h:650:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>    for (j = 0; j < s_pitch; j++)
>                  ^
> 
> Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> (cherry picked from commit ee3468739ed83d862dbbd90397aff5258f8f2c8e)
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  include/linux/fb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index 70c4836..9ce7405 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -641,7 +641,7 @@ static inline void unlock_fb_info(struct fb_info *info)
>  static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch,
>  					   u8 *src, u32 s_pitch, u32 height)
>  {
> -	int i, j;
> +	u32 i, j;
>  
>  	d_pitch -= s_pitch;
>  
>
diff mbox

Patch

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 70c4836..9ce7405 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -641,7 +641,7 @@  static inline void unlock_fb_info(struct fb_info *info)
 static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch,
 					   u8 *src, u32 s_pitch, u32 height)
 {
-	int i, j;
+	u32 i, j;
 
 	d_pitch -= s_pitch;