From patchwork Thu Oct 9 13:40:23 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 3593 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id E1584DE1C2 for ; Fri, 10 Oct 2008 00:40:32 +1100 (EST) X-Original-To: cbe-oss-dev@ozlabs.org Delivered-To: cbe-oss-dev@ozlabs.org Received: from nschwmtas03p.mx.bigpond.com (nschwmtas03p.mx.bigpond.com [61.9.189.143]) by ozlabs.org (Postfix) with ESMTP id 18A58DE02F for ; Fri, 10 Oct 2008 00:40:25 +1100 (EST) Received: from nschwotgx03p.mx.bigpond.com ([121.209.36.216]) by nschwmtas03p.mx.bigpond.com with ESMTP id <20081009134024.HJTG1796.nschwmtas03p.mx.bigpond.com@nschwotgx03p.mx.bigpond.com>; Thu, 9 Oct 2008 13:40:24 +0000 Received: from bubble.grove.modra.org ([121.209.36.216]) by nschwotgx03p.mx.bigpond.com with ESMTP id <20081009134024.CHIB8195.nschwotgx03p.mx.bigpond.com@bubble.grove.modra.org>; Thu, 9 Oct 2008 13:40:24 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 0A3CC170C65C; Fri, 10 Oct 2008 00:10:24 +1030 (CST) Date: Fri, 10 Oct 2008 00:10:23 +1030 From: Alan Modra To: Kazunori Asayama Message-ID: <20081009134023.GA3234@bubble.grove.modra.org> Mail-Followup-To: Kazunori Asayama , Andrew Pinski , Ulrich.Weigand@de.ibm.com, cbe-oss-dev@ozlabs.org, binutils@sourceware.org References: <48E4E2DF.6050908@sm.sony.co.jp> <20081003122641.GI7258@bubble.grove.modra.org> <48E621B9.7070709@sm.sony.co.jp> <48E62C3F.3030107@sm.sony.co.jp> <48E9BB33.9070206@sm.sony.co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <48E9BB33.9070206@sm.sony.co.jp> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-RPD-ScanID: Class unknown; VirusThreatLevel unknown, RefID str=0001.0A150204.48EE09C8.006A,ss=1,fgs=0 Cc: Ulrich.Weigand@de.ibm.com, binutils@sourceware.org, cbe-oss-dev@ozlabs.org Subject: Re: [Cbe-oss-dev] embedspu and execstack X-BeenThere: cbe-oss-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Discussion about Open Source Software for the Cell Broadband Engine List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cbe-oss-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: cbe-oss-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org On Mon, Oct 06, 2008 at 04:16:03PM +0900, Kazunori Asayama wrote: > Andrew Pinski wrote: > > There was an issue with 64bit where the GCCs were not outputting the > > section as on PPC64 with the ABI you don't need stack based execution > > for nested function calls as there are function descriptors which > > contain the chain variable. > > Are you saying about the below? > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21098 Yes, this is an issue if using a version of GNU ld prior to my 2007-02-19 patch to change the default execstack on ppc64. I guess it won't be a problem to always emit .note.GNU-stack, since embedspu is provided in the same package as ld. * embedspu.sh: Pass -Wa,-noexecstack to $CC. Index: binutils/embedspu.sh =================================================================== RCS file: /cvs/src/src/binutils/embedspu.sh,v retrieving revision 1.13 diff -u -p -r1.13 embedspu.sh --- binutils/embedspu.sh 12 May 2008 12:23:13 -0000 1.13 +++ binutils/embedspu.sh 9 Oct 2008 13:35:44 -0000 @@ -146,7 +146,7 @@ main () # 4. Write a struct spe_program_handle to .data. # 5. Write a table of _SPUEAR_ symbols. ${CC} ${FLAGS} -x assembler-with-cpp -nostartfiles -nostdlib \ - -Wa,-mbig -Wl,-r -Wl,-x -o ${OUTFILE} - <