Patchwork mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present

login
register
mail settings
Submitter Roy Tam
Date Oct. 14, 2009, 6:48 a.m.
Message ID <473191350910132348y7e9b9738wdf591b0589a9e86a@mail.gmail.com>
Download mbox | patch
Permalink /patch/35924/
State New
Headers show

Comments

Roy Tam - Oct. 14, 2009, 6:48 a.m.
As i8259 in mips_jazz.c is not connect to isa bus correctly, this
patch fix that.
Aurelien Jarno - Oct. 15, 2009, 9:46 a.m.
On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote:
> As i8259 in mips_jazz.c is not connect to isa bus correctly, this
> patch fix that.

It looks fine. Could you please resend the patch with a Signed-off-by:

> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
> index 3ff367d..281713c 100644
> --- a/hw/mips_jazz.c
> +++ b/hw/mips_jazz.c
> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
> 
>      /* ISA devices */
>      i8259 = i8259_init(env->irq[4]);
> +    isa_bus_new(NULL);
> +    isa_bus_irqs(i8259);
>      DMA_init(0);
>      pit = pit_init(0x40, i8259[0]);
>      pcspk_init(pit);
> 
> 
>

Patch

diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
index 3ff367d..281713c 100644
--- a/hw/mips_jazz.c
+++ b/hw/mips_jazz.c
@@ -185,6 +185,8 @@  void mips_jazz_init (ram_addr_t ram_size,

     /* ISA devices */
     i8259 = i8259_init(env->irq[4]);
+    isa_bus_new(NULL);
+    isa_bus_irqs(i8259);
     DMA_init(0);
     pit = pit_init(0x40, i8259[0]);
     pcspk_init(pit);