Patchwork [net-next,3/3] sctp: update SNMP statiscts when T5 timer expired.

login
register
mail settings
Submitter Vlad Yasevich
Date Oct. 9, 2008, 1:29 p.m.
Message ID <1223558975-1550-5-git-send-email-vladislav.yasevich@hp.com>
Download mbox | patch
Permalink /patch/3592/
State Accepted
Delegated to: David Miller
Headers show

Comments

Vlad Yasevich - Oct. 9, 2008, 1:29 p.m.
The T5 timer is the timer for the over-all shutdown procedure.  If
this timer expires, then shutdown procedure has not completed and we
ABORT the association.  We should update SCTP_MIB_ABORTED and
SCTP_MIB_CURRESTAB  when aborting.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
---
 net/sctp/sm_statefuns.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
David Miller - Oct. 9, 2008, 9:33 p.m.
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Thu,  9 Oct 2008 09:29:35 -0400

> The T5 timer is the timer for the over-all shutdown procedure.  If
> this timer expires, then shutdown procedure has not completed and we
> ABORT the association.  We should update SCTP_MIB_ABORTED and
> SCTP_MIB_CURRESTAB  when aborting.
> 
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>

Also applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index f5094f1..d4c3fbc 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -5489,6 +5489,9 @@  sctp_disposition_t sctp_sf_t5_timer_expire(const struct sctp_endpoint *ep,
 	sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_FAILED,
 			SCTP_PERR(SCTP_ERROR_NO_ERROR));
 
+	SCTP_INC_STATS(SCTP_MIB_ABORTEDS);
+	SCTP_DEC_STATS(SCTP_MIB_CURRESTAB);
+
 	return SCTP_DISPOSITION_DELETE_TCB;
 nomem:
 	return SCTP_DISPOSITION_NOMEM;