Patchwork Re: [PATCH] usb-linux: return USB_RET_STALL on -EPIPE

login
register
mail settings
Submitter Paul Bolle
Date Oct. 13, 2009, 6:53 p.m.
Message ID <1255459986.4712.6.camel@localhost.localdomain>
Download mbox | patch
Permalink /patch/35898/
State New
Headers show

Comments

Paul Bolle - Oct. 13, 2009, 6:53 p.m.
On Tue, 2009-10-13 at 10:23 -0700, Max Krasnyansky wrote: 
> On 10/13/2009 09:22 AM, Anthony Liguori wrote:
> > A SoB is a statement of intent so if you feel you can contribute a SoB
> > is a decision for you to make.  See Documentation/SubmittingPatches in
> > Linux for more details about the ramification of DCO.
> 
> I guess I could've provided the Signed-off-by instead of Acked-by.
> In other words if you're ok with converting my Acked-By to
> Signed-off-by in the aforementioned patch then lets go ahead an do it.
> 
> I could also resend the full patch but I'm totally swamped right now and 
> might not get to doing it this week.
> 
> btw Paul you can also resend and sign off yourself and keep my ack.

I guess this patch should make everybody happy.

I've replaced the verbose commit message with (basically) a longer
version of the commit summary. A search for the summary should turn up
this thread, which will in turn point to previous steps for those
readers really interested.
--- 
usb-linux: return USB_RET_STALL on -EPIPE

If -EPIPE is returned to an asynchronous IN completion async_complete()
should return USB_RET_STALL.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Cc: Mark Burkley <qemu@emutex.com>
Signed-off-by: Max Krasnyansky <maxk@qualcomm.com>
---
 usb-linux.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Patch

diff --git a/usb-linux.c b/usb-linux.c
index 9e5d9c4..d712134 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -275,7 +275,9 @@  static void async_complete(void *opaque)
 
             case -EPIPE:
                 set_halt(s, p->devep);
-                /* fall through */
+		p->len = USB_RET_STALL;
+		break;
+
             default:
                 p->len = USB_RET_NAK;
                 break;