From patchwork Tue Oct 13 09:10:17 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 35834 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 0A782B7B9D for ; Tue, 13 Oct 2009 20:18:45 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752432AbZJMJLI (ORCPT ); Tue, 13 Oct 2009 05:11:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753040AbZJMJLI (ORCPT ); Tue, 13 Oct 2009 05:11:08 -0400 Received: from mail-vw0-f203.google.com ([209.85.212.203]:62006 "EHLO mail-vw0-f203.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006AbZJMJLF (ORCPT ); Tue, 13 Oct 2009 05:11:05 -0400 Received: by vws41 with SMTP id 41so5169212vws.4 for ; Tue, 13 Oct 2009 02:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=wkvAwWoDZ72LWq8thZ7mQ/E/D+mtHhwFGujBoZvKcGs=; b=m32as6il0AxT231tiDno6mUUMA+S4ZsR+o3EPxAkeSVzijEWf5Y9+by+VAk0ETJbRs IsNtjb33eaTX/5RAP8+nXgkTBeaUm9vj02T/hkFHRFIcL1G1u4W3oSV44O8kLe0TUdbg SCsn3VgZijmc7XNj1iAL5Lk9oMszpVm64DpdY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=rJo7LePeCp2nV0T7hKIjmhsSIFvv9g6bkDd7jdduN3RMTcSnjLEeRVXQExvu9SMwuL 4f97eyHog+2O0e291WpWWrRFCalaA886MUMntxvZn84zxJLhUOtUtQFiOcwn3mqPy2tW t8U6FKZajXyeWpnO2lBGu4otxLvAH15kdMU+U= Received: by 10.220.107.162 with SMTP id b34mr6171904vcp.14.1255425027984; Tue, 13 Oct 2009 02:10:27 -0700 (PDT) Received: from localhost.localdomain ([220.110.185.192]) by mx.google.com with ESMTPS id 22sm2741677ywh.4.2009.10.13.02.10.21 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 13 Oct 2009 02:10:26 -0700 (PDT) Date: Tue, 13 Oct 2009 18:10:17 +0900 From: Akinobu Mita To: Andrew Morton Cc: linux-kernel@vger.kernel.org, FUJITA Tomonori , "David S. Miller" , sparclinux@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@ozlabs.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Greg Kroah-Hartman , Lothar Wassmann , linux-usb@vger.kernel.org, Roland Dreier , Yevgeny Petrilin , netdev@vger.kernel.org, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-altix@sgi.com Subject: Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Message-ID: <20091013091017.GA18431@localhost.localdomain> References: <1255076961-21325-1-git-send-email-akinobu.mita@gmail.com> <1255076961-21325-2-git-send-email-akinobu.mita@gmail.com> <20091009164100.85a36188.akpm@linux-foundation.org> <20091013021818.GA3898@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20091013021818.GA3898@localhost.localdomain> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org My user space testing exposed off-by-one error find_next_zero_area in iommu-helper. Some zero area cannot be found by this bug. Subject: [PATCH] Fix off-by-one error in find_next_zero_area Signed-off-by: Akinobu Mita --- lib/iommu-helper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c index 75dbda0..afc58bc 100644 --- a/lib/iommu-helper.c +++ b/lib/iommu-helper.c @@ -19,7 +19,7 @@ again: index = (index + align_mask) & ~align_mask; end = index + nr; - if (end >= size) + if (end > size) return -1; for (i = index; i < end; i++) { if (test_bit(i, map)) {