diff mbox

[2/3] tclap: new package

Message ID 1402412526-24844-3-git-send-email-matthew.weber@rockwellcollins.com
State Superseded
Headers show

Commit Message

Matt Weber June 10, 2014, 3:02 p.m. UTC
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
 package/Config.in       |    1 +
 package/tclap/Config.in |   12 ++++++++++++
 package/tclap/tclap.mk  |   16 ++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/tclap/Config.in
 create mode 100644 package/tclap/tclap.mk

Comments

Thomas Petazzoni June 10, 2014, 8:11 p.m. UTC | #1
Dear Matt Weber,

On Tue, 10 Jun 2014 08:02:05 -0700, Matt Weber wrote:

> diff --git a/package/tclap/Config.in b/package/tclap/Config.in
> new file mode 100644
> index 0000000..e50704b
> --- /dev/null
> +++ b/package/tclap/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_TCLAP
> +	bool "tclap"

This package needs C++ support, so the appropriate 'depends on' +
comment is needed.

> +	help
> +	  This is a small, flexible library that provides a simple interface for
> +	  defining and accessing command line arguments. It was intially inspired

intially -> initially.

> +	  by the user friendly CLAP libary. The difference is that this library is
> +	  templatized, so the argument class is type independent. Type independence
> +	  avoids identical-except-for-type objects, such as IntArg, FloatArg, and
> +	  StringArg. While the library is not strictly compliant with the GNU or
> +	  POSIX standards, it is close.

Please check lines do not exceed 72 chars.

> +	  http://tclap.sourceforge.net/
> diff --git a/package/tclap/tclap.mk b/package/tclap/tclap.mk
> new file mode 100644
> index 0000000..268b90b
> --- /dev/null
> +++ b/package/tclap/tclap.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# tclap
> +#
> +################################################################################
> +
> +TCLAP_VERSION = 1.2.1
> +TCLAP_SITE = http://downloads.sourceforge.net/project/tclap
> +TCLAP_SOURCE = tclap-$(TCLAP_VERSION).tar.gz

Not needed, that's the default.

> +TCLAP_LICENSE = MIT
> +TCLAP_LICENSE_FILES = COPYING
> +
> +TCLAP_INSTALL_STAGING = YES
> +TCLAP_INSTALL_TARGET = NO

A short comment that explains why INSTALL_TARGET = NO is useful. Just
say it's a pure C++ template library, only made of headers.

Thanks!

Thomas
Matt Weber June 11, 2014, 2:03 a.m. UTC | #2
Thomas,

On Tue, Jun 10, 2014 at 3:11 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Matt Weber,
>
> On Tue, 10 Jun 2014 08:02:05 -0700, Matt Weber wrote:
>
>> diff --git a/package/tclap/Config.in b/package/tclap/Config.in
>> new file mode 100644
>> index 0000000..e50704b
>> --- /dev/null
>> +++ b/package/tclap/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_TCLAP
>> +     bool "tclap"
>
> This package needs C++ support, so the appropriate 'depends on' +
> comment is needed.
>
>> +     help
>> +       This is a small, flexible library that provides a simple interface for
>> +       defining and accessing command line arguments. It was intially inspired
>
> intially -> initially.
Agree.

>
>> +       by the user friendly CLAP libary. The difference is that this library is
>> +       templatized, so the argument class is type independent. Type independence
>> +       avoids identical-except-for-type objects, such as IntArg, FloatArg, and
>> +       StringArg. While the library is not strictly compliant with the GNU or
>> +       POSIX standards, it is close.
>
> Please check lines do not exceed 72 chars.
Agree.

>
>> +       http://tclap.sourceforge.net/
>> diff --git a/package/tclap/tclap.mk b/package/tclap/tclap.mk
>> new file mode 100644
>> index 0000000..268b90b
>> --- /dev/null
>> +++ b/package/tclap/tclap.mk
>> @@ -0,0 +1,16 @@
>> +################################################################################
>> +#
>> +# tclap
>> +#
>> +################################################################################
>> +
>> +TCLAP_VERSION = 1.2.1
>> +TCLAP_SITE = http://downloads.sourceforge.net/project/tclap
>> +TCLAP_SOURCE = tclap-$(TCLAP_VERSION).tar.gz
>
> Not needed, that's the default.
Sure.

>
>> +TCLAP_LICENSE = MIT
>> +TCLAP_LICENSE_FILES = COPYING
>> +
>> +TCLAP_INSTALL_STAGING = YES
>> +TCLAP_INSTALL_TARGET = NO
>
> A short comment that explains why INSTALL_TARGET = NO is useful. Just
> say it's a pure C++ template library, only made of headers.
Sure.

<snip>
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 60118ea..ac3af6b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -856,6 +856,7 @@  source "package/pcre/Config.in"
 source "package/popt/Config.in"
 source "package/readline/Config.in"
 source "package/slang/Config.in"
+source "package/tclap/Config.in"
 endmenu
 
 endmenu
diff --git a/package/tclap/Config.in b/package/tclap/Config.in
new file mode 100644
index 0000000..e50704b
--- /dev/null
+++ b/package/tclap/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_TCLAP
+	bool "tclap"
+	help
+	  This is a small, flexible library that provides a simple interface for
+	  defining and accessing command line arguments. It was intially inspired
+	  by the user friendly CLAP libary. The difference is that this library is
+	  templatized, so the argument class is type independent. Type independence
+	  avoids identical-except-for-type objects, such as IntArg, FloatArg, and
+	  StringArg. While the library is not strictly compliant with the GNU or
+	  POSIX standards, it is close.
+
+	  http://tclap.sourceforge.net/
diff --git a/package/tclap/tclap.mk b/package/tclap/tclap.mk
new file mode 100644
index 0000000..268b90b
--- /dev/null
+++ b/package/tclap/tclap.mk
@@ -0,0 +1,16 @@ 
+################################################################################
+#
+# tclap
+#
+################################################################################
+
+TCLAP_VERSION = 1.2.1
+TCLAP_SITE = http://downloads.sourceforge.net/project/tclap
+TCLAP_SOURCE = tclap-$(TCLAP_VERSION).tar.gz
+TCLAP_LICENSE = MIT
+TCLAP_LICENSE_FILES = COPYING
+
+TCLAP_INSTALL_STAGING = YES
+TCLAP_INSTALL_TARGET = NO
+
+$(eval $(autotools-package))