Add FE_NOMASK_ENV return value test
diff mbox

Message ID 002901cf84b4$5ea6c080$1bf44180$@com
State New
Headers show

Commit Message

Wilco June 10, 2014, 2 p.m. UTC
Joseph wrote:
> On Tue, 3 Jun 2014, Wilco wrote:
> 
> > Yes, the test was too strict for trapping implementations, I've updated it.
> 
> This version is OK with the comment at the top of the test fixed to say
> what it actually tests, rather than being copied from a test for a
> different bug.

I've changed the comment at top to say: 

"Test return value when setting FE_NOMASK_ENV (BZ16918, BZ17009)."

Marcus, can you check this in?

Wilco

ChangeLog:
2014-06-10  Wilco  <wdijkstr@arm.com>

	* math/test-fenv-return.c: New file. Test FE_NOMASK_ENV return values.
	* math/Makefile: Add new test test-fenv-return.
---
 math/Makefile           |    2 +-
 math/test-fenv-return.c |  123 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 124 insertions(+), 1 deletion(-)
 create mode 100644 math/test-fenv-return.c

Comments

Marcus Shawcroft June 10, 2014, 2:52 p.m. UTC | #1
On 10 June 2014 15:00, Wilco <wdijkstr@arm.com> wrote:
> Joseph wrote:
>> On Tue, 3 Jun 2014, Wilco wrote:
>>
>> > Yes, the test was too strict for trapping implementations, I've updated it.
>>
>> This version is OK with the comment at the top of the test fixed to say
>> what it actually tests, rather than being copied from a test for a
>> different bug.
>
> I've changed the comment at top to say:
>
> "Test return value when setting FE_NOMASK_ENV (BZ16918, BZ17009)."
>
> Marcus, can you check this in?

Pushed.
/Marcus

Patch
diff mbox

diff --git a/math/Makefile b/math/Makefile
index f337a0e..cd59ce5 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -90,7 +90,7 @@  tests = test-matherr test-fenv atest-exp atest-sincos atest-exp2 basic-test \
 	test-misc test-fpucw test-fpucw-ieee tst-definitions test-tgmath \
 	test-tgmath-ret bug-nextafter bug-nexttoward bug-tgmath1 \
 	test-tgmath-int test-tgmath2 test-powl tst-CMPLX tst-CMPLX2 test-snan \
-	test-fenv-tls test-fenv-preserve $(tests-static)
+	test-fenv-tls test-fenv-preserve test-fenv-return $(tests-static)
 tests-static = test-fpucw-static test-fpucw-ieee-static
 # We do the `long double' tests only if this data type is available and
 # distinct from `double'.
diff --git a/math/test-fenv-return.c b/math/test-fenv-return.c
new file mode 100644
index 0000000..f94a95c
--- /dev/null
+++ b/math/test-fenv-return.c
@@ -0,0 +1,123 @@ 
+/* Test return value when setting FE_NOMASK_ENV (BZ16918, BZ17009).
+   Copyright (C) 2014 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <fenv.h>
+#include <stdio.h>
+#include <math-tests.h>
+
+static int count_errors;
+
+static void
+test_feenableexcept (void)
+{
+#if defined FE_ALL_EXCEPT
+  int res;
+
+  fedisableexcept (FE_ALL_EXCEPT);
+
+  res = feenableexcept (FE_ALL_EXCEPT);
+
+  if (!EXCEPTION_ENABLE_SUPPORTED (FE_ALL_EXCEPT) && (res == -1))
+    {
+      puts ("feenableexcept (FE_ALL_EXCEPT) not supported, cannot test.");
+      return;
+    }
+  else if (res != 0)
+    {
+      puts ("feenableexcept (FE_ALL_EXCEPT) failed");
+      count_errors++;
+    }
+
+  if (fegetexcept () != FE_ALL_EXCEPT)
+    {
+      puts ("feenableexcept did not set all exceptions");
+      count_errors++;
+    }
+#endif
+}
+
+static void
+test_fesetenv (void)
+{
+#if defined FE_NOMASK_ENV && defined FE_ALL_EXCEPT
+  int res;
+
+  fedisableexcept (FE_ALL_EXCEPT);
+
+  res = fesetenv (FE_NOMASK_ENV);
+
+  if (!EXCEPTION_ENABLE_SUPPORTED (FE_ALL_EXCEPT) && (res != 0))
+    {
+      puts ("fesetenv (FE_NOMASK_ENV) not supported, cannot test.");
+      return;
+    }
+  else if (res != 0)
+    {
+      puts ("fesetenv (FE_NOMASK_ENV) failed");
+      count_errors++;
+    }
+
+  if (fegetexcept () != FE_ALL_EXCEPT)
+    {
+      puts ("fesetenv did not set all exceptions");
+      count_errors++;
+    }
+#endif
+}
+
+static void
+test_feupdateenv (void)
+{
+#if defined FE_NOMASK_ENV && defined FE_ALL_EXCEPT
+  int res;
+
+  fedisableexcept (FE_ALL_EXCEPT);
+
+  res = feupdateenv (FE_NOMASK_ENV);
+
+  if (!EXCEPTION_ENABLE_SUPPORTED (FE_ALL_EXCEPT) && (res != 0))
+    {
+      puts ("feupdateenv (FE_NOMASK_ENV)) not supported, cannot test.");
+      return;
+    }
+  else if (res != 0)
+    {
+      puts ("feupdateenv (FE_NOMASK_ENV) failed");
+      count_errors++;
+    }
+
+  if (fegetexcept () != FE_ALL_EXCEPT)
+    {
+      puts ("feupdateenv did not set all exceptions");
+      count_errors++;
+    }
+#endif
+}
+
+static int
+do_test (void)
+{
+  test_feenableexcept ();
+  test_fesetenv ();
+  test_feupdateenv ();
+
+  return count_errors != 0 ? 1 : 0;
+}
+
+#define TEST_FUNCTION do_test ()
+#include "../test-skeleton.c"