diff mbox

[U-Boot] embest/mx6boards: only toggle eMMC usdhc3 RST line on MarSboard

Message ID 53963063.6040006@gmail.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Iain Paton June 9, 2014, 10:08 p.m. UTC
On MarS usdhc3 is eMMC, on RIoT usdhc3 is uSD and eMMC is usdhc4.

Don't run the MarS specific eMMC reset code on usdhc3 when 
board_type == BOARD_IS_RIOTBOARD

Signed-off-by: Iain Paton <ipaton0@gmail.com>
---
 board/embest/mx6boards/mx6boards.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefano Babic Aug. 13, 2014, 7:35 a.m. UTC | #1
Hi Ian,

On 10/06/2014 00:08, Iain Paton wrote:
> On MarS usdhc3 is eMMC, on RIoT usdhc3 is uSD and eMMC is usdhc4.
> 
> Don't run the MarS specific eMMC reset code on usdhc3 when 
> board_type == BOARD_IS_RIOTBOARD
> 
> Signed-off-by: Iain Paton <ipaton0@gmail.com>
> ---
>  board/embest/mx6boards/mx6boards.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Digging deeper in patchwork, I found I have not yet applied this old
patch. Sorry for that.

> diff --git a/board/embest/mx6boards/mx6boards.c b/board/embest/mx6boards/mx6boards.c
> index d06b57d..530ea4f 100644
> --- a/board/embest/mx6boards/mx6boards.c
> +++ b/board/embest/mx6boards/mx6boards.c
> @@ -246,6 +246,7 @@ int board_mmc_init(bd_t *bis)
>  					riotboard_usdhc3_pads,
>  					ARRAY_SIZE(riotboard_usdhc3_pads));
>  				gpio_direction_input(USDHC3_CD_GPIO);
> +			} else {
>  				gpio_direction_output(IMX_GPIO_NR(7, 8) , 0);
>  				udelay(250);
>  				gpio_set_value(IMX_GPIO_NR(7, 8), 1);
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/embest/mx6boards/mx6boards.c b/board/embest/mx6boards/mx6boards.c
index d06b57d..530ea4f 100644
--- a/board/embest/mx6boards/mx6boards.c
+++ b/board/embest/mx6boards/mx6boards.c
@@ -246,6 +246,7 @@  int board_mmc_init(bd_t *bis)
 					riotboard_usdhc3_pads,
 					ARRAY_SIZE(riotboard_usdhc3_pads));
 				gpio_direction_input(USDHC3_CD_GPIO);
+			} else {
 				gpio_direction_output(IMX_GPIO_NR(7, 8) , 0);
 				udelay(250);
 				gpio_set_value(IMX_GPIO_NR(7, 8), 1);