diff mbox

[U-Boot] embestmx6boards: Fix CONFIG_CONSOLE_DEV

Message ID 1402331735-29293-1-git-send-email-fabio.estevam@freescale.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam June 9, 2014, 4:35 p.m. UTC
mars and riot boards use UART2 as console, so CONFIG_CONSOLE_DEV should point
to 'ttymxc1' instead.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Untested as I don't have access to this board.

 include/configs/embestmx6boards.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Iain Paton June 9, 2014, 5:43 p.m. UTC | #1
On 09/06/14 17:35, Fabio Estevam wrote:
> mars and riot boards use UART2 as console, so CONFIG_CONSOLE_DEV should point
> to 'ttymxc1' instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Untested as I don't have access to this board.
> 
>  include/configs/embestmx6boards.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/embestmx6boards.h b/include/configs/embestmx6boards.h
> index eb91c44..1d5fde6 100644
> --- a/include/configs/embestmx6boards.h
> +++ b/include/configs/embestmx6boards.h
> @@ -20,7 +20,7 @@
>  #include <linux/sizes.h>
>  
>  #define CONFIG_MXC_UART_BASE		UART2_BASE
> -#define CONFIG_CONSOLE_DEV		"ttymxc0"
> +#define CONFIG_CONSOLE_DEV		"ttymxc1"
>  #define CONFIG_MMCROOT			"/dev/mmcblk1p2"
>  
>  #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
> 

Tested-by: Iain Paton <ipaton0@gmail.com>

I expect that, like me, most people will never see a problem with this as 
it's not used to define the u-Boot console.
For the kernel console, most people are likely to simply use boot.scr to 
override it or completely replace bootcmd with one that doesn't force 
booting from emmc.

Either way, changing this is the correct thing to do.
Stefano Babic June 17, 2014, 2:36 p.m. UTC | #2
Hi Fabio,

On 09/06/2014 18:35, Fabio Estevam wrote:
> mars and riot boards use UART2 as console, so CONFIG_CONSOLE_DEV should point
> to 'ttymxc1' instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/embestmx6boards.h b/include/configs/embestmx6boards.h
index eb91c44..1d5fde6 100644
--- a/include/configs/embestmx6boards.h
+++ b/include/configs/embestmx6boards.h
@@ -20,7 +20,7 @@ 
 #include <linux/sizes.h>
 
 #define CONFIG_MXC_UART_BASE		UART2_BASE
-#define CONFIG_CONSOLE_DEV		"ttymxc0"
+#define CONFIG_CONSOLE_DEV		"ttymxc1"
 #define CONFIG_MMCROOT			"/dev/mmcblk1p2"
 
 #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)