| Message ID | 1402309780-8118-3-git-send-email-cw00.choi@samsung.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Mon, Jun 09, 2014 at 07:29:40PM +0900, Chanwoo Choi wrote: > +- regulator-initial-state: initial state for suspend state > +- regulator-state-[standby/mem/disk] sub-root node for suspend state > + regulator-volt: voltage consumers may set in suspend state > + regulator-mode: voltage mode in suspend state > + regulator-on-in-suspend: regulator should be on in suspend state > + regulator-off-in-suspend: regulator should be off in suspend state These need to define what the states are in general terms - in particular it's very unclear what standby is and how it differs from suspend to RAM. You also need to define what happens if neither X-in-suspend property is set. > + regulator-state-mem { > + regulator-volt = <1000000>; > + regulator-mode = <0x8>; > + regulator-off-in-suspend; > + }; Probably best to remove mode from this.
diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt index e2c7f1e..b2a4a72 100644 --- a/Documentation/devicetree/bindings/regulator/regulator.txt +++ b/Documentation/devicetree/bindings/regulator/regulator.txt @@ -19,6 +19,12 @@ Optional properties: design requires. This property describes the total system ramp time required due to the combination of internal ramping of the regulator itself, and board design issues such as trace capacitance and load on the supply. +- regulator-initial-state: initial state for suspend state +- regulator-state-[standby/mem/disk] sub-root node for suspend state + regulator-volt: voltage consumers may set in suspend state + regulator-mode: voltage mode in suspend state + regulator-on-in-suspend: regulator should be on in suspend state + regulator-off-in-suspend: regulator should be off in suspend state Deprecated properties: - regulator-compatible: If a regulator chip contains multiple @@ -34,6 +40,12 @@ Example: regulator-max-microvolt = <2500000>; regulator-always-on; vin-supply = <&vin>; + + regulator-state-mem { + regulator-volt = <1000000>; + regulator-mode = <0x8>; + regulator-off-in-suspend; + }; }; Regulator Consumers:
This patch add regulator suspend state to constraint in dt file. The regulation_ constraints structure already has regulator suspend state field as following. The regulator suspend state control the state of regulator according to PM (Power Management) state. - struct regulator_state state_disk - struct regulator_state state_mem - struct regulator_state state_standby Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- Documentation/devicetree/bindings/regulator/regulator.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)