| Message ID | 1402309581-18430-1-git-send-email-yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
Dear Yann E. MORIN, On Mon, 9 Jun 2014 12:26:21 +0200, Yann E. MORIN wrote: > -comment "libbsd needs a toolchain w/ threads" > +comment "libbsd needs an (e)glibc toolchain w/ threads" > depends on ( BR2_i386 || BR2_x86_64 ) > - depends on !BR2_TOOLCHAIN_HAS_THREADS > + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC Is it possible to have a glibc toolchain without threads? I think no. In this case, what is our policy? Should we keep both the glibc and thread dependencies? Thomas
Thomas, All, On 2014-06-09 14:23 +0200, Thomas Petazzoni spake thusly: > On Mon, 9 Jun 2014 12:26:21 +0200, Yann E. MORIN wrote: > > > -comment "libbsd needs a toolchain w/ threads" > > +comment "libbsd needs an (e)glibc toolchain w/ threads" > > depends on ( BR2_i386 || BR2_x86_64 ) > > - depends on !BR2_TOOLCHAIN_HAS_THREADS > > + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC > > Is it possible to have a glibc toolchain without threads? I think no. > In this case, what is our policy? Should we keep both the glibc and > thread dependencies? Indeed, Buildroot considers glibc toolchains have threads. Just for this commit, I would not care we remove the threads dependency, since it is implicit with glibc. However, as I said, libbsd is an Nth-level dependency of QEMU, which I am still p[lanning on submitting. Having static qemu-user programs is very usefull to run foreign chroots, and is only possible with uClibc, so I will have to fix that issue at some point in time. And keeping the threads dependency will just be a warning to me at that point. But for now, do as you prefer. It should be pretty easy to pinpoint build failures at that time. ;-) Do you want me to respin? Regards, Yann E. MORIN.
Dear Yann E. MORIN, On Mon, 9 Jun 2014 14:32:22 +0200, Yann E. MORIN wrote: > > Is it possible to have a glibc toolchain without threads? I think no. > > In this case, what is our policy? Should we keep both the glibc and > > thread dependencies? > > Indeed, Buildroot considers glibc toolchains have threads. > > Just for this commit, I would not care we remove the threads dependency, > since it is implicit with glibc. > > However, as I said, libbsd is an Nth-level dependency of QEMU, which I > am still p[lanning on submitting. Having static qemu-user programs is > very usefull to run foreign chroots, and is only possible with uClibc, > so I will have to fix that issue at some point in time. And keeping the > threads dependency will just be a warning to me at that point. Ok, makes sense. > Do you want me to respin? Nah, that's fine. Remember that we now have musl support, and musl supports static linking, so it could be an alternative to uClibc for some of these use cases :-) Best regards, Thomas
diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in index 8c90aa1..e22226a 100644 --- a/package/libbsd/Config.in +++ b/package/libbsd/Config.in @@ -4,6 +4,7 @@ config BR2_PACKAGE_LIBBSD # architectures: arm, m68k, x86 (and alpha, but we don't care.) depends on ( BR2_i386 || BR2_x86_64 ) depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_TOOLCHAIN_USES_GLIBC help This library provides useful functions commonly found on BSD systems, and lacking on others like GNU systems, thus making @@ -13,6 +14,6 @@ config BR2_PACKAGE_LIBBSD http://libbsd.freedesktop.org/ -comment "libbsd needs a toolchain w/ threads" +comment "libbsd needs an (e)glibc toolchain w/ threads" depends on ( BR2_i386 || BR2_x86_64 ) - depends on !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC