diff mbox

[2/1] libcacard: Clean up dead stores before g_free()

Message ID 1402083032-13852-1-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster June 6, 2014, 7:30 p.m. UTC 
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 libcacard/vcard.c   | 4 ----
 libcacard/vreader.c | 2 --
 2 files changed, 6 deletions(-)

Comments

Eric Blake June 6, 2014, 9:33 p.m. UTC | #1 
On 06/06/2014 01:30 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  libcacard/vcard.c   | 4 ----
>  libcacard/vreader.c | 2 --
>  2 files changed, 6 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox

Patch

diff --git a/libcacard/vcard.c b/libcacard/vcard.c
index bf342aa..87ad516 100644
--- a/libcacard/vcard.c
+++ b/libcacard/vcard.c
@@ -117,10 +117,8 @@  vcard_delete_applet(VCardApplet *applet)
     }
     if (applet->applet_private_free) {
         applet->applet_private_free(applet->applet_private);
-        applet->applet_private = NULL;
     }
     g_free(applet->aid);
-    applet->aid = NULL;
     g_free(applet);
 }
 
@@ -174,8 +172,6 @@  vcard_free(VCard *vcard)
     }
     if (vcard->vcard_private_free) {
         (*vcard->vcard_private_free)(vcard->vcard_private);
-        vcard->vcard_private_free = 0;
-        vcard->vcard_private = 0;
     }
     for (current_applet = vcard->applet_list; current_applet;
                                         current_applet = next_applet) {
diff --git a/libcacard/vreader.c b/libcacard/vreader.c
index ffa05b6..9f42f0f 100644
--- a/libcacard/vreader.c
+++ b/libcacard/vreader.c
@@ -343,8 +343,6 @@  vreader_list_delete(VReaderList *list)
         next_entry = vreader_list_get_next(current_entry);
         vreader_list_entry_delete(current_entry);
     }
-    list->head = NULL;
-    list->tail = NULL;
     g_free(list);
 }