diff mbox

[U-Boot,RESEND,3/3] Use run_command_repeatable()

Message ID 1401991678-3046-4-git-send-email-thomas.betker@freenet.de
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Thomas Betker June 5, 2014, 6:07 p.m. UTC 
Replace run_command() by run_command_repeatable() in places which
depend on the return code to indicate repeatability.

Signed-off-by: Thomas Betker <thomas.betker@rohde-schwarz.com>
---
 common/cli_simple.c | 2 +-
 common/cmd_bedbug.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass June 5, 2014, 6:18 p.m. UTC | #1 
On 5 June 2014 12:07, Thomas Betker <thomas.betker@freenet.de> wrote:
> Replace run_command() by run_command_repeatable() in places which
> depend on the return code to indicate repeatability.
>
> Signed-off-by: Thomas Betker <thomas.betker@rohde-schwarz.com>

Acked-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Tom Rini June 11, 2014, 10:18 p.m. UTC | #2 
On Thu, Jun 05, 2014 at 08:07:58PM +0200, Thomas Betker wrote:

> Replace run_command() by run_command_repeatable() in places which
> depend on the return code to indicate repeatability.
> 
> Signed-off-by: Thomas Betker <thomas.betker@rohde-schwarz.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> Tested-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/cli_simple.c b/common/cli_simple.c
index 413c2eb..222e292 100644
--- a/common/cli_simple.c
+++ b/common/cli_simple.c
@@ -295,7 +295,7 @@  void cli_simple_loop(void)
 		if (len == -1)
 			puts("<INTERRUPT>\n");
 		else
-			rc = run_command(lastcommand, flag);
+			rc = run_command_repeatable(lastcommand, flag);
 
 		if (rc <= 0) {
 			/* invalid command or not repeatable, forget it */
diff --git a/common/cmd_bedbug.c b/common/cmd_bedbug.c
index bdcf712..57a8a3f 100644
--- a/common/cmd_bedbug.c
+++ b/common/cmd_bedbug.c
@@ -238,7 +238,7 @@  void bedbug_main_loop (unsigned long addr, struct pt_regs *regs)
 		if (len == -1)
 			printf ("<INTERRUPT>\n");
 		else
-			rc = run_command(lastcommand, flag);
+			rc = run_command_repeatable(lastcommand, flag);
 
 		if (rc <= 0) {
 			/* invalid command or not repeatable, forget it */