diff mbox

[V6,09/29] qapi event: convert POWERDOWN

Message ID 1401970944-18735-10-git-send-email-wenchaoqemu@gmail.com
State New
Headers show

Commit Message

Wenchao Xia June 5, 2014, 12:22 p.m. UTC
There is no existing comments for POWERDOWN in doc/qmp/qmp-events.txt,
so no change on it like other conversion patch.

Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
---
 qapi-event.json |   10 ++++++++++
 vl.c            |    2 +-
 2 files changed, 11 insertions(+), 1 deletions(-)

Comments

Eric Blake June 13, 2014, 8:02 p.m. UTC | #1
On 06/05/2014 06:22 AM, Wenchao Xia wrote:
> There is no existing comments for POWERDOWN in doc/qmp/qmp-events.txt,
> so no change on it like other conversion patch.

Oddly enough, POWERDOWN _is_ documented in docs/qmp/qmp-spec.txt, but
that reference doesn't need updating with this conversion.

> 
> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
> ---
>  qapi-event.json |   10 ++++++++++
>  vl.c            |    2 +-
>  2 files changed, 11 insertions(+), 1 deletions(-)

> +++ b/vl.c
> @@ -1991,7 +1991,7 @@ void qemu_system_shutdown_request(void)
>  
>  static void qemu_system_powerdown(void)
>  {
> -    monitor_protocol_event(QEVENT_POWERDOWN, NULL);
> +    qapi_event_send_powerdown(NULL);

Modulo my comment in 8/29 on whether we even need an errp argument,

Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox

Patch

diff --git a/qapi-event.json b/qapi-event.json
index b2a943f..fbdbc7c 100644
--- a/qapi-event.json
+++ b/qapi-event.json
@@ -10,3 +10,13 @@ 
 # Since: 2.1
 ##
 { 'event': 'SHUTDOWN' }
+
+##
+# @POWERDOWN
+#
+# Emitted when the virtual machine is powered down through the power control
+# system, such as via ACPI.
+#
+# Since: 2.1
+##
+{ 'event': 'POWERDOWN' }
diff --git a/vl.c b/vl.c
index 273d237..69ad0e9 100644
--- a/vl.c
+++ b/vl.c
@@ -1991,7 +1991,7 @@  void qemu_system_shutdown_request(void)
 
 static void qemu_system_powerdown(void)
 {
-    monitor_protocol_event(QEVENT_POWERDOWN, NULL);
+    qapi_event_send_powerdown(NULL);
     notifier_list_notify(&powerdown_notifiers, NULL);
 }