From patchwork Thu Jun 5 09:04:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 356237 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 08F4C14007F for ; Thu, 5 Jun 2014 19:03:47 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=bd+0 xI7iIlsZ2HZvLBrUJegYHQolqFBEejq7xGWKdt/SHQprj3dMGQp0yuoOuQyOu3oZ sW+vhe+lOGeiNkUqFf2Ex+Vn7sEcvxghVyFL0kF7D5Zs1cXZ5WRI4TVI3xVt2v0N eNbm4JWEqqXk0d3KGdPbFfnTMRKi78B2afHEnKI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=oLz0eH1PIg Boi1RXqWp+NvAfoUY=; b=m7X9Xz0t/5aJ0Wk9CEn+1MCTWaIkS2TYpTv+gTzSiD rakKQTP/y0KawOe4xTTsoBA1mCn39VWLoeCfHQRDMxVqKDwsytcYAXYWFia6Gloc gDnrWCFsiDnxHfpzqPeYLlV1zUocnEiFa8wYingNettihtnB0vkr+1wurlRSkomW w= Received: (qmail 6125 invoked by alias); 5 Jun 2014 09:03:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 6107 invoked by uid 89); 5 Jun 2014 09:03:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Date: Thu, 5 Jun 2014 14:34:55 +0530 From: Siddhesh Poyarekar To: Roland McGrath Cc: Konstantin Serebryany , GNU C Library Subject: Re: [PATCH] remove one nested function from nptl/allocatestack.c Message-ID: <20140605090455.GB9145@spoyarek.pnq.redhat.com> References: <20140604171623.362652C39B4@topped-with-meat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140604171623.362652C39B4@topped-with-meat.com> User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16) On Wed, Jun 04, 2014 at 10:16:23AM -0700, Roland McGrath wrote: > That is fine, though it wouldn't hurt to improve the commentary and use > bool while you're there. I wonder if it would be better to just inline this function: diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c index 1e22f7d..b779529 100644 --- a/nptl/allocatestack.c +++ b/nptl/allocatestack.c @@ -830,26 +830,23 @@ __reclaim_stacks (void) if (add_p) { - /* We always add at the beginning of the list. So in this - case we only need to check the beginning of these lists. */ - int check_list (list_t *l) - { - if (l->next->prev != l) - { - assert (l->next->prev == elem); - - elem->next = l->next; - elem->prev = l; - l->next = elem; - - return 1; - } - - return 0; - } - - if (check_list (&stack_used) == 0) - (void) check_list (&stack_cache); + /* We always add at the beginning of the list. So in this case we + only need to check the beginning of these lists to see if the + pointers at the head of the list are inconsistent. */ + list_t *l = NULL; + + if (stack_used.next->prev != &stack_used) + l = &stack_used; + else if (stack_cache.next->prev != &stack_cache) + l = &stack_cache; + + if (l) + { + assert (l->next->prev == elem); + elem->next = l->next; + elem->prev = l; + l->next = elem; + } } else {