diff mbox

[v2,5/6] pch_gbe: reset PHY before first configuration

Message ID 1401958387-8154-5-git-send-email-alexander.stein@systec-electronic.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Alexander Stein June 5, 2014, 8:53 a.m. UTC 
From: Daniel Krueger <daniel.krueger@systec-electronic.com>

It is a good idea to perform a PHY software reset, but is should be done
before performing the first configuration.

Signed-off-by: Daniel Krueger <daniel.krueger@systec-electronic.com>
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
index 3fa9a8f..dc9f0d3 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
@@ -316,6 +316,8 @@  void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw)
 	if (ret)
 		netdev_err(adapter->netdev, "Error: mii_ethtool_gset\n");
 
+	pch_gbe_phy_sw_reset(hw);
+
 	ethtool_cmd_speed_set(&cmd, hw->mac.link_speed);
 	cmd.duplex = hw->mac.link_duplex;
 	cmd.advertising = hw->phy.autoneg_advertised;
@@ -324,8 +326,6 @@  void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw)
 	if (ret)
 		netdev_err(adapter->netdev, "Error: mii_ethtool_sset\n");
 
-	pch_gbe_phy_sw_reset(hw);
-
 	pch_gbe_phy_read_reg_miic(hw, PHY_PHYSP_CONTROL, &mii_reg);
 	mii_reg |= PHYSP_CTRL_ASSERT_CRS_TX;
 	pch_gbe_phy_write_reg_miic(hw, PHY_PHYSP_CONTROL, mii_reg);