From patchwork Fri Oct 9 09:43:52 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 35607 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3710AB7B98 for ; Fri, 9 Oct 2009 20:47:38 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MwC17-0001wb-Aq; Fri, 09 Oct 2009 09:44:05 +0000 Received: from mail-vw0-f187.google.com ([209.85.212.187]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MwC11-0001vT-FL for linux-mtd@lists.infradead.org; Fri, 09 Oct 2009 09:44:04 +0000 Received: by vws17 with SMTP id 17so451147vws.24 for ; Fri, 09 Oct 2009 02:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=3NlWnoPSvCOfyCsJrmCVKcfv2Dsg4/F/lgKibsPfRfQ=; b=L0xHmrDvzUyHkPX0o23/w9kteeMvlbWoO76B9yx39Wu8ps8QZmFiWMxNduiSEodMED P4eUBhRr/zJSW0iSyTcUgG6S5f/cq6BnfTWafjrlTKGW++HFFpKiF5ifLCDL00mzdbY6 qzxArpE+7uKROhjidgfoJM/bFpskH7bAD+2sw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=i999+3RYVzKzKF20U3jCmzDhUXzsf8ZBPYUnZTGWxltry8QTeWb6LYR9SBNEcqTu// Z0tgBEuTxSzzTK+/bjLCPZftkQS0/oFnk14oVwssjbyOpzTrlfSP4qo0sTCsvAvvENpq FNbdNzGeVZs4Xuvub6DRs99QvVpC6VPgyjMEo= Received: by 10.220.114.12 with SMTP id c12mr3408645vcq.109.1255081436953; Fri, 09 Oct 2009 02:43:56 -0700 (PDT) Received: from localhost ([220.110.185.192]) by mx.google.com with ESMTPS id 20sm515282yxe.2.2009.10.09.02.43.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 09 Oct 2009 02:43:56 -0700 (PDT) From: Akinobu Mita To: linux-mtd@lists.infradead.org Subject: [PATCH] mtd: cleanup mtd_oobtest Date: Fri, 9 Oct 2009 18:43:52 +0900 Message-Id: <1255081432-22080-1-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.5.4.3 In-Reply-To: <> References: <> X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20091009_054359_600923_6FA7F80D X-CRM114-Status: GOOD ( 10.38 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- _SUMMARY_ Cc: Artem Bityutskiy , David Woodhouse , Akinobu Mita X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org - Remove unnecessary memset for bbt All entries will be initialized at a few lines below - Remove unnecessary initialization for mtd->erasesize - Use write_whole_device() Cc: David Woodhouse Cc: Artem Bityutskiy Cc: linux-mtd@lists.infradead.org Signed-off-by: Akinobu Mita --- drivers/mtd/tests/mtd_oobtest.c | 18 ++++-------------- 1 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/mtd/tests/mtd_oobtest.c b/drivers/mtd/tests/mtd_oobtest.c index 5553cd4..5813920 100644 --- a/drivers/mtd/tests/mtd_oobtest.c +++ b/drivers/mtd/tests/mtd_oobtest.c @@ -343,7 +343,6 @@ static int scan_for_bad_eraseblocks(void) printk(PRINT_PREF "error: cannot allocate memory\n"); return -ENOMEM; } - memset(bbt, 0 , ebcnt); printk(PRINT_PREF "scanning for bad eraseblocks\n"); for (i = 0; i < ebcnt; ++i) { @@ -392,7 +391,6 @@ static int __init mtd_oobtest_init(void) mtd->writesize, ebcnt, pgcnt, mtd->oobsize); err = -ENOMEM; - mtd->erasesize = mtd->erasesize; readbuf = kmalloc(mtd->erasesize, GFP_KERNEL); if (!readbuf) { printk(PRINT_PREF "error: cannot allocate memory\n"); @@ -476,18 +474,10 @@ static int __init mtd_oobtest_init(void) use_len_max = mtd->ecclayout->oobavail; vary_offset = 1; simple_srand(5); - printk(PRINT_PREF "writing OOBs of whole device\n"); - for (i = 0; i < ebcnt; ++i) { - if (bbt[i]) - continue; - err = write_eraseblock(i); - if (err) - goto out; - if (i % 256 == 0) - printk(PRINT_PREF "written up to eraseblock %u\n", i); - cond_resched(); - } - printk(PRINT_PREF "written %u eraseblocks\n", i); + + err = write_whole_device(); + if (err) + goto out; /* Check all eraseblocks */ use_offset = 0;