| Message ID | 1401832319-2247-1-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tue, Jun 03, 2014 at 06:51:59PM -0300, Gustavo Zacarias wrote: > We need $INCLUDES in BUILD_CFLAGS otherwise cross-compilation is broken > now that util/subst.c uses config.h (from commit 2873927d15). > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > configure.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.in b/configure.in > index 448a292..8bac870 100644 > --- a/configure.in > +++ b/configure.in > @@ -1382,7 +1382,7 @@ if test $cross_compiling = no; then > BUILD_CFLAGS="$CFLAGS $CPPFLAGS $INCLUDES -DHAVE_CONFIG_H" > BUILD_LDFLAGS="$LDFLAGS" > else > - BUILD_CFLAGS= > + BUILD_CFLAGS="$INCLUDES -DHAVE_CONFIG_H" I would think that BUILD_CFLAGS="-I$(top_builddir)/lib -DHAVE_CONFIG_H" ... would be safer, since $INCLUDES could potentially include some $CPPFLAGS that could be specific to the target architecture. Yes? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/05/2014 08:55 PM, Theodore Ts'o wrote: > I would think that > > BUILD_CFLAGS="-I$(top_builddir)/lib -DHAVE_CONFIG_H" > > ... would be safer, since $INCLUDES could potentially include some > $CPPFLAGS that could be specific to the target architecture. > > Yes? Not really, since that way it's missing config.h, still failing: ----- cd ./util ; /usr/bin/make subst make[2]: Entering directory `/home/gustavoz/b/test/output/build/e2fsprogs-1.42.10/util' CREATE dirpaths.h CC subst.c subst.c:8:20: fatal error: config.h: No such file or directory compilation terminated. ----- Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/configure.in b/configure.in index 448a292..8bac870 100644 --- a/configure.in +++ b/configure.in @@ -1382,7 +1382,7 @@ if test $cross_compiling = no; then BUILD_CFLAGS="$CFLAGS $CPPFLAGS $INCLUDES -DHAVE_CONFIG_H" BUILD_LDFLAGS="$LDFLAGS" else - BUILD_CFLAGS= + BUILD_CFLAGS="$INCLUDES -DHAVE_CONFIG_H" BUILD_LDFLAGS= fi AC_SUBST(BUILD_CFLAGS)
We need $INCLUDES in BUILD_CFLAGS otherwise cross-compilation is broken now that util/subst.c uses config.h (from commit 2873927d15). Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- configure.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)