diff mbox

[v4,13/29] target-ppc: Move POWER8 TCE Address control (TAR) to a helper

Message ID 1401787684-31895-14-git-send-email-aik@ozlabs.ru
State New
Headers show

Commit Message

Alexey Kardashevskiy June 3, 2014, 9:27 a.m. UTC
This moves TAR SPR to a helper. Later this helper will be
called from generalized init_proc_book3s_64().

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 target-ppc/translate_init.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

Comments

Tom Musta June 3, 2014, 4:48 p.m. UTC | #1
On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
> This moves TAR SPR to a helper. Later this helper will be
> called from generalized init_proc_book3s_64().
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  target-ppc/translate_init.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index aa88727..d6557f2 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7523,6 +7523,14 @@ static void gen_spr_book3s_purr(CPUPPCState *env)
>  #endif
>  }
>  
> +static void gen_spr_power8_tce_address_control(CPUPPCState *env)
> +{
> +    spr_register(env, SPR_TAR, "TAR",
> +                 &spr_read_generic, &spr_write_generic,
> +                 &spr_read_generic, &spr_write_generic,
> +                 0x00000000);
> +}
> +
>  static void init_proc_book3s_64(CPUPPCState *env, int version)
>  {
>      gen_spr_ne_601(env);
> @@ -7933,11 +7941,7 @@ static void init_proc_POWER8(CPUPPCState *env)
>      /* inherit P7 */
>      init_proc_POWER7(env);
>  
> -    /* P8 supports the TAR */
> -    spr_register(env, SPR_TAR, "TAR",
> -                 &spr_read_generic, &spr_write_generic,
> -                 &spr_read_generic, &spr_write_generic,
> -                 0x00000000);
> +    gen_spr_power8_tce_address_control(env);
>  }
>  
>  POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data)
> 

Reviewed-by: Tom Musta <tommusta@gmail.com>
diff mbox

Patch

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index aa88727..d6557f2 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -7523,6 +7523,14 @@  static void gen_spr_book3s_purr(CPUPPCState *env)
 #endif
 }
 
+static void gen_spr_power8_tce_address_control(CPUPPCState *env)
+{
+    spr_register(env, SPR_TAR, "TAR",
+                 &spr_read_generic, &spr_write_generic,
+                 &spr_read_generic, &spr_write_generic,
+                 0x00000000);
+}
+
 static void init_proc_book3s_64(CPUPPCState *env, int version)
 {
     gen_spr_ne_601(env);
@@ -7933,11 +7941,7 @@  static void init_proc_POWER8(CPUPPCState *env)
     /* inherit P7 */
     init_proc_POWER7(env);
 
-    /* P8 supports the TAR */
-    spr_register(env, SPR_TAR, "TAR",
-                 &spr_read_generic, &spr_write_generic,
-                 &spr_read_generic, &spr_write_generic,
-                 0x00000000);
+    gen_spr_power8_tce_address_control(env);
 }
 
 POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data)