| Message ID | 1401782556-5210-1-git-send-email-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
On Tue, Jun 3, 2014 at 10:02 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > These symbols are supposed to be selected by the drivers actually needing > them. The only situation where it would make sense to enable them without a > driver selecting them is when an out-of-tree pinctrl driver is used or > for compile testing. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Changes since v1: > - allow enabling with COMPILE_TEST Had some mixed feelings and back-and-forth about this patch (I like the visual feedback in menuconfig) but eventually decided that simplicity is better so applied the patch (for v3.17) Yours, Linus Walleij
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 33f9dc1f14fd..5f1af97a054b 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -11,10 +11,10 @@ menu "Pin controllers" depends on PINCTRL config PINMUX - bool "Support pin multiplexing controllers" + bool "Support pin multiplexing controllers" if COMPILE_TEST config PINCONF - bool "Support pin configuration controllers" + bool "Support pin configuration controllers" if COMPILE_TEST config GENERIC_PINCONF bool
These symbols are supposed to be selected by the drivers actually needing them. The only situation where it would make sense to enable them without a driver selecting them is when an out-of-tree pinctrl driver is used or for compile testing. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Changes since v1: - allow enabling with COMPILE_TEST drivers/pinctrl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)