| Message ID | 1401780790-17830-3-git-send-email-antoine.tenart@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jun 03, 2014 at 09:33:10AM +0200, Antoine Ténart wrote: > Enable the I2C0 and I2C2 for the Marvell Berlin BG2G DMP. I2C1 and I2C3 > are also working on this board, but no devices seemed to be there. Hi Antoine Does this mean that IC0 and I2C2 have devices on them? Could you also add nodes for the devices? Andrew
Hi Andrew, On Tue, Jun 03, 2014 at 10:05:22AM +0200, Andrew Lunn wrote: > On Tue, Jun 03, 2014 at 09:33:10AM +0200, Antoine Ténart wrote: > > Enable the I2C0 and I2C2 for the Marvell Berlin BG2G DMP. I2C1 and I2C3 > > are also working on this board, but no devices seemed to be there. > > Does this mean that IC0 and I2C2 have devices on them? Could you also > add nodes for the devices? No devices I can add for now. I you prefer we can drop this patch, keep the other one and enable i2c nodes for the BG2Q DMP when they will be needed. Antoine
On Wed, Jun 04, 2014 at 06:48:41PM +0200, Antoine Ténart wrote: > Hi Andrew, > > On Tue, Jun 03, 2014 at 10:05:22AM +0200, Andrew Lunn wrote: > > On Tue, Jun 03, 2014 at 09:33:10AM +0200, Antoine Ténart wrote: > > > Enable the I2C0 and I2C2 for the Marvell Berlin BG2G DMP. I2C1 and I2C3 > > > are also working on this board, but no devices seemed to be there. > > > > Does this mean that IC0 and I2C2 have devices on them? Could you also > > add nodes for the devices? > > No devices I can add for now. I you prefer we can drop this patch, keep > the other one and enable i2c nodes for the BG2Q DMP when they will be > needed. Hi Antoine I was just wondering how you tested it, without having any devices? Is it that the devices on the bus don't have mainline drivers? I don't see a reason not to commit both. At least it allows i2c-detect to work and see what is on the bus, even if we cannot drive them. Thanks Andrew
On Wed, Jun 04, 2014 at 07:03:40PM +0200, Andrew Lunn wrote: > On Wed, Jun 04, 2014 at 06:48:41PM +0200, Antoine Ténart wrote: > > > > On Tue, Jun 03, 2014 at 10:05:22AM +0200, Andrew Lunn wrote: > > > On Tue, Jun 03, 2014 at 09:33:10AM +0200, Antoine Ténart wrote: > > > > Enable the I2C0 and I2C2 for the Marvell Berlin BG2G DMP. I2C1 and I2C3 > > > > are also working on this board, but no devices seemed to be there. > > > > > > Does this mean that IC0 and I2C2 have devices on them? Could you also > > > add nodes for the devices? > > > > No devices I can add for now. I you prefer we can drop this patch, keep > > the other one and enable i2c nodes for the BG2Q DMP when they will be > > needed. > > I was just wondering how you tested it, without having any devices? I tested with the i2ctools. I could see one device on each bus at the address it should be. I also tested the pin muxing configurations. I don't have lots of information on these I2C buses, at least my test results match what I know. > Is it that the devices on the bus don't have mainline drivers? Not with I2C support. Antoine
On 06/03/2014 09:33 AM, Antoine Ténart wrote: > Enable the I2C0 and I2C2 for the Marvell Berlin BG2G DMP. I2C1 and I2C3 > are also working on this board, but no devices seemed to be there. > > Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> Applied to berlin/dt with Andrew's Reviewed-by. Thanks! > --- > arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > index 995150f93795..a357ce02a64e 100644 > --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > @@ -34,6 +34,14 @@ > status = "okay"; > }; > > +&i2c0 { > + status = "okay"; > +}; > + > +&i2c2 { > + status = "okay"; > +}; > + > &uart0 { > status = "okay"; > }; >
diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts index 995150f93795..a357ce02a64e 100644 --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts @@ -34,6 +34,14 @@ status = "okay"; }; +&i2c0 { + status = "okay"; +}; + +&i2c2 { + status = "okay"; +}; + &uart0 { status = "okay"; };
Enable the I2C0 and I2C2 for the Marvell Berlin BG2G DMP. I2C1 and I2C3 are also working on this board, but no devices seemed to be there. Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> --- arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 8 ++++++++ 1 file changed, 8 insertions(+)