[06/16] net: remove id field from NICInfo

Submitted by Mark McLoughlin on Oct. 8, 2009, 6:58 p.m.

Details

Message ID 1255028312-28180-7-git-send-email-markmc@redhat.com
State Under Review
Headers show

Commit Message

Mark McLoughlin Oct. 8, 2009, 6:58 p.m.
Just use the name field instead since we now use the id paramater as
the name, if supplied. Only implication with this change is that if
id is not supplied, the value of the name paramater is used as an
id.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 hw/pci.c |    4 ++--
 net.c    |    4 ----
 net.h    |    1 -
 3 files changed, 2 insertions(+), 7 deletions(-)

Patch hide | download patch | download mbox

diff --git a/hw/pci.c b/hw/pci.c
index 49651d0..abf07ca 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -857,8 +857,8 @@  PCIDevice *pci_nic_init(NICInfo *nd, const char *default_model,
 
     pci_dev = pci_create(bus, devfn, pci_nic_names[i]);
     dev = &pci_dev->qdev;
-    if (nd->id)
-        dev->id = qemu_strdup(nd->id);
+    if (nd->name)
+        dev->id = qemu_strdup(nd->name);
     dev->nd = nd;
     if (qdev_init(dev) < 0)
         return NULL;
diff --git a/net.c b/net.c
index 8895e87..87dcf06 100644
--- a/net.c
+++ b/net.c
@@ -2414,9 +2414,6 @@  static int net_init_nic(QemuOpts *opts, Monitor *mon, const char *name)
     if (name) {
         nd->name = qemu_strdup(name);
     }
-    if (qemu_opts_id(opts)) {
-        nd->id = qemu_strdup(qemu_opts_id(opts));
-    }
     if (qemu_opt_get(opts, "model")) {
         nd->model = qemu_strdup(qemu_opt_get(opts, "model"));
     }
@@ -3032,7 +3029,6 @@  void net_client_uninit(NICInfo *nd)
     qemu_free(nd->model);
     qemu_free(nd->name);
     qemu_free(nd->devaddr);
-    qemu_free(nd->id);
 
     nd->used = 0;
 }
diff --git a/net.h b/net.h
index 49e160d..164ea3d 100644
--- a/net.h
+++ b/net.h
@@ -98,7 +98,6 @@  struct NICInfo {
     char *model;
     char *name;
     char *devaddr;
-    char *id;
     VLANState *vlan;
     VLANClientState *vc;
     void *private;