diff mbox

[1/1] ti-gfx: select fbset as it is a runtime dependency

Message ID 1401634635-20325-1-git-send-email-hadrien.boutteville@gmail.com
State Changes Requested
Headers show

Commit Message

Hadrien Boutteville June 1, 2014, 2:57 p.m. UTC 
Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
---
 package/ti-gfx/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Spenser Gilliland June 1, 2014, 3:30 p.m. UTC | #1 
Hadrien,

On Jun 1, 2014 7:57 AM, "Hadrien Boutteville" <hadrien.boutteville@gmail.com>
wrote:
>
> Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
> ---
>  package/ti-gfx/Config.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/ti-gfx/Config.in b/package/ti-gfx/Config.in
> index 3e8648e..f1f3a07 100644
> --- a/package/ti-gfx/Config.in
> +++ b/package/ti-gfx/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_TI_GFX
>         select BR2_PACKAGE_HAS_LIBEGL
>         select BR2_PACKAGE_HAS_LIBGLES
>         select BR2_PACKAGE_HAS_POWERVR
> +       select BR2_PACKAGE_FBSET # Runtime dependency only
>         depends on BR2_LINUX_KERNEL && BR2_TOOLCHAIN_USES_GLIBC && BR2_arm
>         help
>           Graphics libraries for TI boards.
> --
> 1.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Fbset is available in either the package or as part of busybox.  Is there a
good way to support both?

Thanks,
Spenser
Hadrien Boutteville June 1, 2014, 4:08 p.m. UTC | #2 
Spenser,

On Sun, 1 Jun 2014 10:30:10 -0500, Spenser Gilliland wrote:
> On Jun 1, 2014 7:57 AM, "Hadrien Boutteville"
> <hadrien.boutteville@gmail.com <mailto:hadrien.boutteville@gmail.com>>
> wrote:
>>
>> Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com
> <mailto:hadrien.boutteville@gmail.com>>
>> ---
>>  package/ti-gfx/Config.in | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/ti-gfx/Config.in b/package/ti-gfx/Config.in
>> index 3e8648e..f1f3a07 100644
>> --- a/package/ti-gfx/Config.in
>> +++ b/package/ti-gfx/Config.in
>> @@ -3,6 +3,7 @@ config BR2_PACKAGE_TI_GFX
>>         select BR2_PACKAGE_HAS_LIBEGL
>>         select BR2_PACKAGE_HAS_LIBGLES
>>         select BR2_PACKAGE_HAS_POWERVR
>> +       select BR2_PACKAGE_FBSET # Runtime dependency only
>>         depends on BR2_LINUX_KERNEL && BR2_TOOLCHAIN_USES_GLIBC && BR2_arm
>>         help
>>           Graphics libraries for TI boards.
>> --
>> 1.9.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net <mailto:buildroot@busybox.net>
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> Fbset is available in either the package or as part of busybox.  Is
> there a good way to support both?

Erf, yes, I didn't pay attention to that... According to Thomas the
solution would be to select fbset in the default busybox configuration,
and select it in ti-gfx only if busybox is not used.

Regards,

Hadrien
diff mbox

Patch

diff --git a/package/ti-gfx/Config.in b/package/ti-gfx/Config.in
index 3e8648e..f1f3a07 100644
--- a/package/ti-gfx/Config.in
+++ b/package/ti-gfx/Config.in
@@ -3,6 +3,7 @@  config BR2_PACKAGE_TI_GFX
 	select BR2_PACKAGE_HAS_LIBEGL
 	select BR2_PACKAGE_HAS_LIBGLES
 	select BR2_PACKAGE_HAS_POWERVR
+	select BR2_PACKAGE_FBSET # Runtime dependency only
 	depends on BR2_LINUX_KERNEL && BR2_TOOLCHAIN_USES_GLIBC && BR2_arm
 	help
 	  Graphics libraries for TI boards.