diff mbox

dns_resolver: Do not accept domain names longer than 255 chars

Message ID 1401554673-16311-1-git-send-email-manuel.schoelling@gmx.de
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

Manuel Schölling May 31, 2014, 4:44 p.m. UTC
According to RFC1035 "[...] the total length of a domain name (i.e.,
label octets and label length octets) is restricted to 255 octets or
less."

Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
---
 net/dns_resolver/dns_query.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller June 5, 2014, 7:06 a.m. UTC | #1
From: Manuel Schölling <manuel.schoelling@gmx.de>
Date: Sat, 31 May 2014 18:44:33 +0200

> According to RFC1035 "[...] the total length of a domain name (i.e.,
> label octets and label length octets) is restricted to 255 octets or
> less."
> 
> Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c
index e7b6d53..e0fde29 100644
--- a/net/dns_resolver/dns_query.c
+++ b/net/dns_resolver/dns_query.c
@@ -94,7 +94,7 @@  int dns_query(const char *type, const char *name, size_t namelen,
 
 	if (!namelen)
 		namelen = strlen(name);
-	if (namelen < 3)
+	if (namelen < 3 || namelen > 255)
 		return -EINVAL;
 	desclen += namelen + 1;