diff mbox

[v1,72/72] qapi: Extract nbd-server-stop definition into qapi/block.json

Message ID 1401537111-10221-73-git-send-email-benoit.canet@irqsave.net
State New
Headers show

Commit Message

Benoît Canet May 31, 2014, 11:51 a.m. UTC
Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
 qapi-schema.json | 10 ----------
 qapi/block.json  | 10 ++++++++++
 2 files changed, 10 insertions(+), 10 deletions(-)

Comments

Eric Blake June 3, 2014, 3:01 p.m. UTC | #1
On 05/31/2014 05:51 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  qapi-schema.json | 10 ----------
>  qapi/block.json  | 10 ++++++++++
>  2 files changed, 10 insertions(+), 10 deletions(-)

45-72: Reviewed-by: Eric Blake <eblake@redhat.com>

If you resend this series for any reason, PLEASE consolidate into fewer
patches. As long as the types are copied out of qapi-schema.json in the
same order that they are copied into block.json, it's much faster to
review that the code motion was done correctly if there is only one such
patch describing the motion to block.json than to read lots of tiny
patches one per struct/command.
diff mbox

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index 2ad42e4..14b498b 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -2463,16 +2463,6 @@ 
 { 'command': 'screendump', 'data': {'filename': 'str'} }
 
 ##
-# @nbd-server-stop:
-#
-# Stop QEMU's embedded NBD server, and unregister all devices previously
-# added via @nbd-server-add.
-#
-# Since: 1.3.0
-##
-{ 'command': 'nbd-server-stop' }
-
-##
 # @ChardevFile:
 #
 # Configuration info for file chardevs.
diff --git a/qapi/block.json b/qapi/block.json
index dbe12e1..61c463a 100644
--- a/qapi/block.json
+++ b/qapi/block.json
@@ -154,3 +154,13 @@ 
 ##
 { 'command': 'nbd-server-add', 'data': {'device': 'str', '*writable': 'bool'} }
 
+##
+# @nbd-server-stop:
+#
+# Stop QEMU's embedded NBD server, and unregister all devices previously
+# added via @nbd-server-add.
+#
+# Since: 1.3.0
+##
+{ 'command': 'nbd-server-stop' }
+