| Message ID | 20140529122313.9724.203.stgit@fimbulvetr.bsc.es |
|---|---|
| State | New |
| Headers | show |
On 05/29/2014 05:23 AM, Lluís Vilanova wrote: > > #include "helper.h" > +#define HELPER_GEN_TRACE_PROXY 1 > +#include "trace/generated-helpers.h" > +#undef HELPER_GEN_TRACE_PROXY > #include "tcg-runtime.h" > Continued from patch 5... you don't need the HELPER_GEN_TRACE_PROXY define, just two include statements here. r~
Richard Henderson writes: > On 05/29/2014 05:23 AM, Lluís Vilanova wrote: >> >> #include "helper.h" >> +#define HELPER_GEN_TRACE_PROXY 1 >> +#include "trace/generated-helpers.h" >> +#undef HELPER_GEN_TRACE_PROXY >> #include "tcg-runtime.h" >> > Continued from patch 5... you don't need the HELPER_GEN_TRACE_PROXY define, > just two include statements here. Right, that will be much nicer. I'll send a new series (if there's no more comments on the rest). Lluis
diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h index a04a034..ba5a379 100644 --- a/include/exec/helper-gen.h +++ b/include/exec/helper-gen.h @@ -57,6 +57,9 @@ static inline void glue(gen_helper_, name)(dh_retvar_decl(ret) \ } #include "helper.h" +#define HELPER_GEN_TRACE_PROXY 1 +#include "trace/generated-helpers.h" +#undef HELPER_GEN_TRACE_PROXY #include "tcg-runtime.h" #undef DEF_HELPER_FLAGS_0 diff --git a/include/exec/helper-proto.h b/include/exec/helper-proto.h index 828951c..effdd43 100644 --- a/include/exec/helper-proto.h +++ b/include/exec/helper-proto.h @@ -27,6 +27,7 @@ dh_ctype(ret) HELPER(name) (dh_ctype(t1), dh_ctype(t2), dh_ctype(t3), \ dh_ctype(t4), dh_ctype(t5)); #include "helper.h" +#include "trace/generated-helpers.h" #include "tcg-runtime.h" #undef DEF_HELPER_FLAGS_0 diff --git a/include/exec/helper-tcg.h b/include/exec/helper-tcg.h index d704c81..79fa3c8 100644 --- a/include/exec/helper-tcg.h +++ b/include/exec/helper-tcg.h @@ -36,6 +36,7 @@ | dh_sizemask(t5, 5) }, #include "helper.h" +#include "trace/generated-helpers.h" #include "tcg-runtime.h" #undef DEF_HELPER_FLAGS_0
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu> --- include/exec/helper-gen.h | 3 +++ include/exec/helper-proto.h | 1 + include/exec/helper-tcg.h | 1 + 3 files changed, 5 insertions(+)