diff mbox

[v2,1/1] qt5base: stop qt stripping installed libraries

Message ID 1401348717-16224-1-git-send-email-will_wagner@carallon.com
State Accepted
Headers show

Commit Message

Will Wagner May 29, 2014, 7:31 a.m. UTC 
From: Will Wagner <will_wagner@carallon.com>

By default the 'make install' step for qt5base will strip all the binaries
and libraries when they are installed to staging. This hinders debugging
as the libraries in staging dir have been stripped and is unnecessary
as buildroot will strip all files on the target

Signed-off-by: Will Wagner <will_wagner@carallon.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
Changes v1 ->v2
  - fix spelling in commit log
  - add review by Yann
  
 .../qt5/qt5base/qt5base-0002-mkspecs-files.patch   |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Fatih Aşıcı May 29, 2014, 8:41 a.m. UTC | #1 
On Thursday 29 May 2014 10:31:57 will_wagner@carallon.com wrote:
> From: Will Wagner <will_wagner@carallon.com>
> 
> By default the 'make install' step for qt5base will strip all the binaries
> and libraries when they are installed to staging. This hinders debugging
> as the libraries in staging dir have been stripped and is unnecessary
> as buildroot will strip all files on the target
> 
> Signed-off-by: Will Wagner <will_wagner@carallon.com>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Reviewed-by: Fatih Aşıcı <fatih.asici@gmail.com>

Regards,
Fatih
Peter Korsgaard May 29, 2014, 9:20 p.m. UTC | #2 
>>>>> "will" == will wagner <will_wagner@carallon.com> writes:

 > From: Will Wagner <will_wagner@carallon.com>
 > By default the 'make install' step for qt5base will strip all the binaries
 > and libraries when they are installed to staging. This hinders debugging
 > as the libraries in staging dir have been stripped and is unnecessary
 > as buildroot will strip all files on the target

 > Signed-off-by: Will Wagner <will_wagner@carallon.com>
 > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > ---
 > Changes v1 ->v2
 >   - fix spelling in commit log
 >   - add review by Yann

Committed, thanks.
diff mbox

Patch

diff --git a/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch b/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
index 06436b4..6283bbe 100644
--- a/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
+++ b/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
@@ -14,13 +14,14 @@  Index: b/mkspecs/devices/linux-buildroot-g++/qmake.conf
 ===================================================================
 --- /dev/null
 +++ b/mkspecs/devices/linux-buildroot-g++/qmake.conf
-@@ -0,0 +1,11 @@
+@@ -0,0 +1,12 @@
 +include(../common/linux_device_pre.conf)
 +
 +#modifications to gcc-base.conf
 +QMAKE_CFLAGS           += $${BR_COMPILER_CFLAGS}
 +QMAKE_CXXFLAGS         += $${BR_COMPILER_CXXFLAGS}
 +QMAKE_CXXFLAGS_RELEASE += -O3
++CONFIG                 += nostrip
 +
 +QMAKE_LIBS             += -lrt -lpthread -ldl
 +