Patchwork [LPIA,Hardy,LUM,netbook-lpia,branch] unionfs: enable delete=all unionfs mount option

login
register
mail settings
Submitter Colin King
Date Oct. 7, 2009, 6:04 p.m.
Message ID <1254938690.4051.24.camel@lenovo>
Download mbox | patch
Permalink /patch/35353/
State Accepted
Headers show

Comments

Colin King - Oct. 7, 2009, 6:04 p.m.
For: Hardy Lum, netbook-lpia branch 

LP#445673

https://bugs.launchpad.net/ubuntu/+bug/445673

unionfs does not have the delete=all mount option compiled
in. Enable this by adding -DUNIONFS_DELETE_ALL to CFLAGS.

Without the delete=all option configured one cannot mount
a unionfs without having to fallback on using whiteouts which
can consume a considerable amount of inodes to mark deleted
files. This can cause problems on unionfs systems with limited
inode reservations where storage is very limited.

Attached: the patch
Tim Gardner - Oct. 7, 2009, 6:51 p.m.
Colin Ian King wrote:
> For: Hardy Lum, netbook-lpia branch 
> 
> LP#445673
> 
> https://bugs.launchpad.net/ubuntu/+bug/445673
> 
> unionfs does not have the delete=all mount option compiled
> in. Enable this by adding -DUNIONFS_DELETE_ALL to CFLAGS.
> 
> Without the delete=all option configured one cannot mount
> a unionfs without having to fallback on using whiteouts which
> can consume a considerable amount of inodes to mark deleted
> files. This can cause problems on unionfs systems with limited
> inode reservations where storage is very limited.
> 
> Attached: the patch
> 
> 

ACK. Do you think this might also apply to Jaunty? Or did we use aufs ?
They all run together.
Andy Whitcroft - Oct. 8, 2009, 10:35 a.m.
On Wed, Oct 07, 2009 at 07:04:50PM +0100, Colin Ian King wrote:
> For: Hardy Lum, netbook-lpia branch 
> 
> LP#445673
> 
> https://bugs.launchpad.net/ubuntu/+bug/445673
> 
> unionfs does not have the delete=all mount option compiled
> in. Enable this by adding -DUNIONFS_DELETE_ALL to CFLAGS.
> 
> Without the delete=all option configured one cannot mount
> a unionfs without having to fallback on using whiteouts which
> can consume a considerable amount of inodes to mark deleted
> files. This can cause problems on unionfs systems with limited
> inode reservations where storage is very limited.
> 

Sounds reasonable and the patch looks pretty safe.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Stefan Bader - Oct. 8, 2009, 4:44 p.m.
Colin Ian King wrote:
> For: Hardy Lum, netbook-lpia branch 
> 
> LP#445673
> 
> https://bugs.launchpad.net/ubuntu/+bug/445673
> 
> unionfs does not have the delete=all mount option compiled
> in. Enable this by adding -DUNIONFS_DELETE_ALL to CFLAGS.
> 
> Without the delete=all option configured one cannot mount
> a unionfs without having to fallback on using whiteouts which
> can consume a considerable amount of inodes to mark deleted
> files. This can cause problems on unionfs systems with limited
> inode reservations where storage is very limited.
> 
> Attached: the patch
> 
> 
Applied to hardy-lum

Patch

From 07932dd65714d0fa292f59468eddfc01b659afec Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Wed, 7 Oct 2009 17:50:50 +0000
Subject: [PATCH] UBUNTU: unionfs: enable delete=all mount option

BugLink: https://bugs.launchpad.net/ubuntu/+bug/445673

unionfs does not have the delete=all mount option compiled
in. Enable this by adding -DUNIONFS_DELETE_ALL to CFLAGS.

Without the delete=all option configured one cannot mount
a unionfs without having to fallback on using whiteouts which
can consume a considerable amount of inodes to mark deleted
files. This can cause problems on unionfs systems with limited
inode reservations where storage is limited.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 ubuntu/fs/unionfs/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ubuntu/fs/unionfs/Makefile b/ubuntu/fs/unionfs/Makefile
index 5d553c0..195fe1d 100644
--- a/ubuntu/fs/unionfs/Makefile
+++ b/ubuntu/fs/unionfs/Makefile
@@ -3,7 +3,7 @@  SUP_MAJOR= 2
 SUP_MINOR= 6
 SUP_PATCH= 18
 
-EXTRA_CFLAGS+=-DUNIONFS_VERSION=\"${UNIONFS_VERSION}\" -DSUP_MAJOR=${SUP_MAJOR} -DSUP_MINOR=${SUP_MINOR} -DSUP_PATCH=${SUP_PATCH} -DUNIONFS_UNSUPPORTED
+EXTRA_CFLAGS+=-DUNIONFS_VERSION=\"${UNIONFS_VERSION}\" -DSUP_MAJOR=${SUP_MAJOR} -DSUP_MINOR=${SUP_MINOR} -DSUP_PATCH=${SUP_PATCH} -DUNIONFS_UNSUPPORTED -DUNIONFS_DELETE_ALL
 
 # This will enable full debugging support
 # EXTRA_CFLAGS+=-DUNIONFS_DEBUG
-- 
1.5.4.3