| Message ID | 1401290047-30005-3-git-send-email-benoit.taine@lip6.fr |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2014-05-28 at 17:14 +0200, Benoit Taine wrote: > This issue was reported by coccicheck using the semantic patch > at scripts/coccinelle/api/resource_size.cocci Slightly associated trivial note: > diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c [] > @@ -1419,8 +1419,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) > > netdev_dbg(ndev, "IO address start :0x%08x\n", > res->start); > - netdev_dbg(ndev, "IO address size :%d\n", > - res->end - res->start + 1); > + netdev_dbg(ndev, "IO address size :%d\n", resource_size(res)); May be better using: netdev_dbg(ndev, "IO :%pR\n", res) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Benoit Taine <benoit.taine@lip6.fr> Date: Wed, 28 May 2014 17:14:07 +0200 > @@ -1419,8 +1419,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) > > netdev_dbg(ndev, "IO address start :0x%08x\n", > res->start); > - netdev_dbg(ndev, "IO address size :%d\n", > - res->end - res->start + 1); > + netdev_dbg(ndev, "IO address size :%d\n", resource_size(res)); > netdev_dbg(ndev, "IO address (mapped) :0x%p\n", > pldat->net_base); Please replace all of this with %pR as suggested by Joe, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 422d9b5..dc2f15c 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -1361,7 +1361,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) __lpc_eth_clock_enable(pldat, true); /* Map IO space */ - pldat->net_base = ioremap(res->start, res->end - res->start + 1); + pldat->net_base = ioremap(res->start, resource_size(res)); if (!pldat->net_base) { dev_err(&pdev->dev, "failed to map registers\n"); ret = -ENOMEM; @@ -1419,8 +1419,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) netdev_dbg(ndev, "IO address start :0x%08x\n", res->start); - netdev_dbg(ndev, "IO address size :%d\n", - res->end - res->start + 1); + netdev_dbg(ndev, "IO address size :%d\n", resource_size(res)); netdev_dbg(ndev, "IO address (mapped) :0x%p\n", pldat->net_base); netdev_dbg(ndev, "IRQ number :%d\n", ndev->irq);
This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/resource_size.cocci Signed-off-by: Benoit Taine <benoit.taine@lip6.fr> --- Not compile tested, due incompatible architecture. drivers/net/ethernet/nxp/lpc_eth.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html