| Message ID | 5859dbf7-5c9a-438a-9023-5ec682ca73c9@BAMAIL02.ba.imgtec.org |
|---|---|
| State | New |
| Headers | show |
"Steve Ellcey " <sellcey@mips.com> writes: > The recent comdat group changes broke the mips build because mips.c > was not including cgraph.h. I am checking in the following patch > as obvious to fix the mips build. Wasn't that fixed by: 2014-05-26 Jan Hubicka <hubicka@ucw.cz> * tree.h (decl_comdat_group): Declare. * cgraph.h (symtab_in_same_comdat_p): Move offline to ... * tree.c (decl_comdat_group): Here. ? Thanks, Richard
On Tue, 2014-05-27 at 17:12 +0100, Richard Sandiford wrote: > "Steve Ellcey " <sellcey@mips.com> writes: > > The recent comdat group changes broke the mips build because mips.c > > was not including cgraph.h. I am checking in the following patch > > as obvious to fix the mips build. > > Wasn't that fixed by: > > 2014-05-26 Jan Hubicka <hubicka@ucw.cz> > > * tree.h (decl_comdat_group): Declare. > * cgraph.h (symtab_in_same_comdat_p): Move offline to ... > * tree.c (decl_comdat_group): Here. > > ? > > Thanks, > Richard It didn't fix the build for me. I still got this failure after that patch: /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c: In function 'void mips_start_unique_function(const char*)': /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c:6278:27: error: 'cgraph_create_node' was not declared in this scope make[2]: *** [mips.o] Error 1 When I grepped for cgraph_create_node I found it in cgraph.h. Steve Ellcey sellcey@mips.com
Steve Ellcey <sellcey@mips.com> writes: > On Tue, 2014-05-27 at 17:12 +0100, Richard Sandiford wrote: >> "Steve Ellcey " <sellcey@mips.com> writes: >> > The recent comdat group changes broke the mips build because mips.c >> > was not including cgraph.h. I am checking in the following patch >> > as obvious to fix the mips build. >> >> Wasn't that fixed by: >> >> 2014-05-26 Jan Hubicka <hubicka@ucw.cz> >> >> * tree.h (decl_comdat_group): Declare. >> * cgraph.h (symtab_in_same_comdat_p): Move offline to ... >> * tree.c (decl_comdat_group): Here. >> >> ? >> >> Thanks, >> Richard > > It didn't fix the build for me. I still got this failure after that > patch: > > /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c: In function > 'void mips_start_unique_function(const char*)': > /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c:6278:27: > error: 'cgraph_create_node' was not declared in this scope > make[2]: *** [mips.o] Error 1 Ah, sorry, hadn't realised we had a direct caller there. Richard
On Tue, 2014-05-27 at 17:49 +0100, Richard Sandiford wrote: > > It didn't fix the build for me. I still got this failure after that > > patch: > > > > /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c: In function > > 'void mips_start_unique_function(const char*)': > > /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c:6278:27: > > error: 'cgraph_create_node' was not declared in this scope > > make[2]: *** [mips.o] Error 1 > > Ah, sorry, hadn't realised we had a direct caller there. > > Richard No problem, I probably should have included the error message in my original email. Steve Ellcey sellcey@mips.com
> On Tue, 2014-05-27 at 17:49 +0100, Richard Sandiford wrote: > > > > It didn't fix the build for me. I still got this failure after that > > > patch: > > > > > > /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c: In function > > > 'void mips_start_unique_function(const char*)': > > > /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c:6278:27: > > > error: 'cgraph_create_node' was not declared in this scope > > > make[2]: *** [mips.o] Error 1 > > > > Ah, sorry, hadn't realised we had a direct caller there. > > > > Richard > > No problem, I probably should have included the error message in my > original email. Thanks for fixing it. Indeed I introduced direct caller to some targets and did not double check includes (most targets include cgraph anyway) Honza > > Steve Ellcey > sellcey@mips.com
diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c index eefcfd2..46e6b81 100644 --- a/gcc/config/mips/mips.c +++ b/gcc/config/mips/mips.c @@ -71,6 +71,7 @@ along with GCC; see the file COPYING3. If not see #include "opts.h" #include "tree-pass.h" #include "context.h" +#include "cgraph.h" /* True if X is an UNSPEC wrapper around a SYMBOL_REF or LABEL_REF. */ #define UNSPEC_ADDRESS_P(X) \