Message ID | 1401125835-21765-15-git-send-email-armbru@redhat.com |
---|---|
State | New |
Headers | show |
The Monday 26 May 2014 à 19:37:15 (+0200), Markus Armbruster wrote : > Introduced in commit 661a0f7. Spotted by Coverity. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 62ea27e..d118da5 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -1455,7 +1455,7 @@ static int img_convert(int argc, char **argv) > ret = bdrv_parse_cache_flags(cache, &flags); > if (ret < 0) { > error_report("Invalid cache option: %s", cache); > - return -1; > + goto out; > } > > out_bs = bdrv_new_open("target", out_filename, out_fmt, flags, true, quiet); > -- > 1.9.3 > > Reviewed-by: Benoit Canet <benoit@irqsave.net>
diff --git a/qemu-img.c b/qemu-img.c index 62ea27e..d118da5 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1455,7 +1455,7 @@ static int img_convert(int argc, char **argv) ret = bdrv_parse_cache_flags(cache, &flags); if (ret < 0) { error_report("Invalid cache option: %s", cache); - return -1; + goto out; } out_bs = bdrv_new_open("target", out_filename, out_fmt, flags, true, quiet);
Introduced in commit 661a0f7. Spotted by Coverity. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)