diff mbox

[04/14] block: Plug memory leak on brv_open_image() error path

Message ID 1401125835-21765-5-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster May 26, 2014, 5:37 p.m. UTC 
Introduced in commit da557a.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 block.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Benoît Canet May 27, 2014, 10:26 a.m. UTC | #1 
The Monday 26 May 2014 à 19:37:05 (+0200), Markus Armbruster wrote :
> Introduced in commit da557a.  Spotted by Coverity.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  block.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block.c b/block.c
> index 40c5e1a..1996f84 100644
> --- a/block.c
> +++ b/block.c
> @@ -1196,6 +1196,7 @@ int bdrv_open_image(BlockDriverState **pbs, const char *filename,
>                         bdref_key);
>              ret = -EINVAL;
>          }
> +        QDECREF(image_options);
>          goto done;
>      }
>  
> -- 
> 1.9.3
> 
> 
Reviewed-by: Benoit Canet <benoit@irqsave.net>
diff mbox

Patch

diff --git a/block.c b/block.c
index 40c5e1a..1996f84 100644
--- a/block.c
+++ b/block.c
@@ -1196,6 +1196,7 @@  int bdrv_open_image(BlockDriverState **pbs, const char *filename,
                        bdref_key);
             ret = -EINVAL;
         }
+        QDECREF(image_options);
         goto done;
     }