diff mbox

[libbid] : Fix "variable ‘Ql’ set but not used" warnings

Message ID CAFULd4YKcbzNQs54h9yMP3r_riFKrh-9BBfy_3X+VbY07mM+vA@mail.gmail.com
State New
Headers show

Commit Message

Uros Bizjak May 26, 2014, 4:52 p.m. UTC 
Hello!

Attached patch fixes several "variable ‘Ql’ set but not used" warnings
in bid128_div.c and bid64_div.c libbid sources. We can simply use
__mul_128x128_high functions when lowpart is not needed.

2014-05-26  Uros Bizjak  <ubizjak@gmail.com>

    * bid128_div.c (BID128_FUNCTION_ARG2): Remove unused variable 'Ql'.
    Call __mul_128x128_high instead of __mul_128x128_full.
    (TYPE0_FUNCTION_ARGTYPE1_ARGTYPE2): Ditto.
    (BID128_FUNCTION_ARGTYPE1_ARG128): Ditto.
    (BID128_FUNCTION_ARG128_ARGTYPE2): Ditto.
    * bid64_div.c (TYPE0_FUNCTION_ARGTYPE1_ARG128): Ditto.
    (TYPE0_FUNCTION_ARG128_ARGTYPE2): Ditto.
    (TYPE0_FUNCTION_ARG128_ARG128): Ditto.

Bootstrapped and regression tested on x86_64-pc-linux-gnu {,-m32}.

HJ, should this be fixed upstream first?

Uros.

Comments

Uros Bizjak June 10, 2014, 6:29 p.m. UTC | #1 
On Mon, May 26, 2014 at 6:52 PM, Uros Bizjak <ubizjak@gmail.com> wrote:

> Attached patch fixes several "variable ‘Ql’ set but not used" warnings
> in bid128_div.c and bid64_div.c libbid sources. We can simply use
> __mul_128x128_high functions when lowpart is not needed.
>
> 2014-05-26  Uros Bizjak  <ubizjak@gmail.com>
>
>     * bid128_div.c (BID128_FUNCTION_ARG2): Remove unused variable 'Ql'.
>     Call __mul_128x128_high instead of __mul_128x128_full.
>     (TYPE0_FUNCTION_ARGTYPE1_ARGTYPE2): Ditto.
>     (BID128_FUNCTION_ARGTYPE1_ARG128): Ditto.
>     (BID128_FUNCTION_ARG128_ARGTYPE2): Ditto.
>     * bid64_div.c (TYPE0_FUNCTION_ARGTYPE1_ARG128): Ditto.
>     (TYPE0_FUNCTION_ARG128_ARGTYPE2): Ditto.
>     (TYPE0_FUNCTION_ARG128_ARG128): Ditto.
>
> Bootstrapped and regression tested on x86_64-pc-linux-gnu {,-m32}.

The patch was OK'd offline by H.J.

Committed to mainline SVN.

Uros.
diff mbox

Patch

Index: bid128_div.c
===================================================================
--- bid128_div.c	(revision 210927)
+++ bid128_div.c	(working copy)
@@ -36,7 +36,7 @@  extern UINT8 packed_10000_zeros[];
 BID128_FUNCTION_ARG2 (bid128_div, x, y)
 
      UINT256 CA4, CA4r, P256;
-     UINT128 CX, CY, T128, CQ, CR, CA, TP128, Qh, Ql, res;
+     UINT128 CX, CY, T128, CQ, CR, CA, TP128, Qh, res;
      UINT64 sign_x, sign_y, T, carry64, D, Q_high, Q_low, QX, PD,
        valid_y;
      int_float fx, fy, f64;
@@ -239,7 +239,7 @@  if (!CA4.w[0] && !CA4.w[1])
     if (d5 < nzeros)
       nzeros = d5;
     // get P*(2^M[extra_digits])/10^extra_digits
-    __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+    __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
     // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
     amount = recip_scale[nzeros];
@@ -365,7 +365,7 @@  if (!CA4.w[0] && !CA4.w[1])
 
       if (nzeros) {
 	// get P*(2^M[extra_digits])/10^extra_digits
-	__mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+	__mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
 	//now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
 	amount = recip_scale[nzeros];
@@ -487,7 +487,7 @@  TYPE0_FUNCTION_ARGTYPE1_ARGTYPE2 (UINT128, bid128d
 				  UINT64, y)
 
      UINT256 CA4, CA4r, P256;
-     UINT128 CX, CY, T128, CQ, CR, CA, TP128, Qh, Ql, res;
+     UINT128 CX, CY, T128, CQ, CR, CA, TP128, Qh, res;
      UINT64 sign_x, sign_y, T, carry64, D, Q_high, Q_low, QX, PD,
        valid_y;
      int_float fx, fy, f64;
@@ -701,7 +701,7 @@  __div_256_by_128 (&CQ, &CA4, CY);
       if (d5 < nzeros)
 	nzeros = d5;
       // get P*(2^M[extra_digits])/10^extra_digits
-      __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+      __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
       //__mul_128x128_to_256(P256, CQ, reciprocals10_128[nzeros]);Qh.w[1]=P256.w[3];Qh.w[0]=P256.w[2];
 
       // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
@@ -829,7 +829,7 @@  __div_256_by_128 (&CQ, &CA4, CY);
 
 	if (nzeros) {
 	  // get P*(2^M[extra_digits])/10^extra_digits
-	  __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+	  __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
 	  // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
 	  amount = recip_scale[nzeros];
@@ -946,7 +946,7 @@  BID_RETURN (res);
 
 BID128_FUNCTION_ARGTYPE1_ARG128 (bid128dq_div, UINT64, x, y)
      UINT256 CA4, CA4r, P256;
-     UINT128 CX, CY, T128, CQ, CR, CA, TP128, Qh, Ql, res;
+     UINT128 CX, CY, T128, CQ, CR, CA, TP128, Qh, res;
      UINT64 sign_x, sign_y, T, carry64, D, Q_high, Q_low, QX, valid_y,
        PD;
      int_float fx, fy, f64;
@@ -1155,7 +1155,7 @@  __div_256_by_128 (&CQ, &CA4, CY);
       if (d5 < nzeros)
 	nzeros = d5;
       // get P*(2^M[extra_digits])/10^extra_digits
-      __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+      __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
       //__mul_128x128_to_256(P256, CQ, reciprocals10_128[nzeros]);Qh.w[1]=P256.w[3];Qh.w[0]=P256.w[2];
 
       // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
@@ -1285,7 +1285,7 @@  __div_256_by_128 (&CQ, &CA4, CY);
 
 	if (nzeros) {
 	  // get P*(2^M[extra_digits])/10^extra_digits
-	  __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+	  __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
 	  // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
 	  amount = recip_scale[nzeros];
@@ -1403,7 +1403,7 @@  BID_RETURN (res);
 
 BID128_FUNCTION_ARG128_ARGTYPE2 (bid128qd_div, x, UINT64, y)
      UINT256 CA4, CA4r, P256;
-     UINT128 CX, CY, T128, CQ, CR, CA, TP128, Qh, Ql, res;
+     UINT128 CX, CY, T128, CQ, CR, CA, TP128, Qh, res;
      UINT64 sign_x, sign_y, T, carry64, D, Q_high, Q_low, QX, PD,
        valid_y;
      int_float fx, fy, f64;
@@ -1607,7 +1607,7 @@  __div_256_by_128 (&CQ, &CA4, CY);
       if (d5 < nzeros)
 	nzeros = d5;
       // get P*(2^M[extra_digits])/10^extra_digits
-      __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+      __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
       //__mul_128x128_to_256(P256, CQ, reciprocals10_128[nzeros]);Qh.w[1]=P256.w[3];Qh.w[0]=P256.w[2];
 
       // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
@@ -1735,7 +1735,7 @@  __div_256_by_128 (&CQ, &CA4, CY);
 
 	if (nzeros) {
 	  // get P*(2^M[extra_digits])/10^extra_digits
-	  __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+	  __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
 	  // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
 	  amount = recip_scale[nzeros];
Index: bid64_div.c
===================================================================
--- bid64_div.c	(revision 210927)
+++ bid64_div.c	(working copy)
@@ -520,7 +520,7 @@  bid64_div (UINT64 x,
 TYPE0_FUNCTION_ARGTYPE1_ARG128 (UINT64, bid64dq_div, UINT64, x, y)
      UINT256 CA4 =
        { {0x0ull, 0x0ull, 0x0ull, 0x0ull} }, CA4r, P256, QB256;
-UINT128 CX, CY, T128, CQ, CQ2, CR, CA, TP128, Qh, Ql, Tmp;
+UINT128 CX, CY, T128, CQ, CQ2, CR, CA, TP128, Qh, Tmp;
 UINT64 sign_x, sign_y, T, carry64, D, Q_low, QX, valid_y, PD, res;
 int_float fx, fy, f64;
 UINT32 QX32, tdigit[3], digit, digit_h, digit_low;
@@ -600,7 +600,7 @@  if (!valid_y) {
     Tmp.w[1] = (CY.w[1] & 0x00003fffffffffffull);
     Tmp.w[0] = CY.w[0];
     TP128 = reciprocals10_128[18];
-    __mul_128x128_full (Qh, Ql, Tmp, TP128);
+    __mul_128x128_high (Qh, Tmp, TP128);
     amount = recip_scale[18];
     __shr_128 (Tmp, Qh, amount);
     res = (CY.w[1] & 0xfc00000000000000ull) | Tmp.w[0];
@@ -746,7 +746,7 @@  if (!done) {
       if (d5 < nzeros)
 	nzeros = d5;
       // get P*(2^M[extra_digits])/10^extra_digits
-      __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+      __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
       // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
       amount = recip_scale[nzeros];
@@ -806,7 +806,7 @@  if (!done) {
 
 	if (nzeros) {
 	  // get P*(2^M[extra_digits])/10^extra_digits
-	  __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+	  __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
 	  // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
 	  amount = recip_scale[nzeros];
@@ -934,7 +934,7 @@  TYPE0_FUNCTION_ARG128_ARGTYPE2 (UINT64, bid64qd_di
 
      UINT256 CA4 =
        { {0x0ull, 0x0ull, 0x0ull, 0x0ull} }, CA4r, P256, QB256;
-UINT128 CX, CY, T128, CQ, CQ2, CR, CA, TP128, Qh, Ql, Tmp;
+UINT128 CX, CY, T128, CQ, CQ2, CR, CA, TP128, Qh, Tmp;
 UINT64 sign_x, sign_y, T, carry64, D, Q_low, QX, PD, res, valid_y;
 int_float fx, fy, f64;
 UINT32 QX32, tdigit[3], digit, digit_h, digit_low;
@@ -960,7 +960,7 @@  if (!unpack_BID128_value (&sign_x, &exponent_x, &C
       Tmp.w[1] = (CX.w[1] & 0x00003fffffffffffull);
       Tmp.w[0] = CX.w[0];
       TP128 = reciprocals10_128[18];
-      __mul_128x128_full (Qh, Ql, Tmp, TP128);
+      __mul_128x128_high (Qh, Tmp, TP128);
       amount = recip_scale[18];
       __shr_128 (Tmp, Qh, amount);
       res = (CX.w[1] & 0xfc00000000000000ull) | Tmp.w[0];
@@ -1172,7 +1172,7 @@  if (!done) {
       if (d5 < nzeros)
 		nzeros = d5;
       // get P*(2^M[extra_digits])/10^extra_digits
-      __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+      __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
       //__mul_128x128_to_256(P256, CQ, reciprocals10_128[nzeros]);Qh.w[1]=P256.w[3];Qh.w[0]=P256.w[2];
 
       // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
@@ -1234,7 +1234,7 @@  if (!done) {
 
 	if (nzeros) {
 	  // get P*(2^M[extra_digits])/10^extra_digits
-	  __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+	  __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
 	  // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
 	  amount = recip_scale[nzeros];
@@ -1371,7 +1371,7 @@  extern UINT8 packed_10000_zeros[];
 TYPE0_FUNCTION_ARG128_ARG128 (UINT64, bid64qq_div, x, y)
      UINT256 CA4 =
        { {0x0ull, 0x0ull, 0x0ull, 0x0ull} }, CA4r, P256, QB256;
-UINT128 CX, CY, T128, CQ, CQ2, CR, CA, TP128, Qh, Ql, Tmp;
+UINT128 CX, CY, T128, CQ, CQ2, CR, CA, TP128, Qh, Tmp;
 UINT64 sign_x, sign_y, T, carry64, D, Q_low, QX, valid_y, PD, res;
 int_float fx, fy, f64;
 UINT32 QX32, tdigit[3], digit, digit_h, digit_low;
@@ -1397,7 +1397,7 @@  if (!unpack_BID128_value (&sign_x, &exponent_x, &C
       Tmp.w[1] = (CX.w[1] & 0x00003fffffffffffull);
       Tmp.w[0] = CX.w[0];
       TP128 = reciprocals10_128[18];
-      __mul_128x128_full (Qh, Ql, Tmp, TP128);
+      __mul_128x128_high (Qh, Tmp, TP128);
       amount = recip_scale[18];
       __shr_128 (Tmp, Qh, amount);
       res = (CX.w[1] & 0xfc00000000000000ull) | Tmp.w[0];
@@ -1456,7 +1456,7 @@  if (!valid_y) {
       Tmp.w[1] = (CY.w[1] & 0x00003fffffffffffull);
       Tmp.w[0] = CY.w[0];
       TP128 = reciprocals10_128[18];
-      __mul_128x128_full (Qh, Ql, Tmp, TP128);
+      __mul_128x128_high (Qh, Tmp, TP128);
       amount = recip_scale[18];
       __shr_128 (Tmp, Qh, amount);
       res = (CY.w[1] & 0xfc00000000000000ull) | Tmp.w[0];
@@ -1606,7 +1606,7 @@  if (!done) {
       if (d5 < nzeros)
 	nzeros = d5;
       // get P*(2^M[extra_digits])/10^extra_digits
-      __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+      __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
       //__mul_128x128_to_256(P256, CQ, reciprocals10_128[nzeros]);Qh.w[1]=P256.w[3];Qh.w[0]=P256.w[2];
 
       // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
@@ -1668,7 +1668,7 @@  if (!done) {
 
 	if (nzeros) {
 	  // get P*(2^M[extra_digits])/10^extra_digits
-	  __mul_128x128_full (Qh, Ql, CQ, reciprocals10_128[nzeros]);
+	  __mul_128x128_high (Qh, CQ, reciprocals10_128[nzeros]);
 
 	  // now get P/10^extra_digits: shift Q_high right by M[extra_digits]-128
 	  amount = recip_scale[nzeros];