Ping #1: [patch,arm] Add GCC runtime library exceptions to files that go into libgcc

This is Ping #1 for

https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00747.html

an addendum that adds runtime library exception to two more files
in the ARM backend (arm-opts.h, arm-cores.def) that are included in libgcc.

Ok to apply?

Johann


Am 05/10/2014 02:51 AM, schrieb Ian Lance Taylor:
> Georg-Johann Lay <avr@jlay.de> writes:
>
>> This patch adds GCC Runtime Library Exception to files that go into
>> libgcc because libgcc2.c includes tm.h and libgcc_tm.h.
>>
>> Most of these files contain much code, some used by libgcc, some
>> not. Some potential users of (lib)gcc have objections that missing RLE
>> might "infect" their target code.
>>
>> Even though I know that this is actually not the case and the FSF is
>> fine with target code linked against libgcc, it's pointless to argue
>> in that direction. At least this is my personal experience with
>> advocates.
>>
>> I am aware that there was effort for better separation of libgcc and
>> GCC, but obviously this separation has not yet been achieved.
>>
>> This this ok for trunk?
>>
>> And is there anything special about license changes w.r.t FSF that I
>> have to take into account?  CCed Ian so that someone from the GCC
>> steering committee can have a look.
>
> I think this is unnecessary but fine.

Thanks.

Yes, I know it's not needed... yet it can increase acceptance of GCC.

I opened a PR61152 for this so that it's clearer for why the Runtime Exceptions 
will be added:

http://gcc.gnu.org/PR61152

Added two files included by arm.h I missed; is it in order to apply this, too?

And is it in order to apply/backport this to the 4.9 branch? From source 
perspective the changes are trivial enough.

Johann



	PR libgcc/61152
	* config/arm/arm-opts.h (License): Add GCC Runtime Library Exception.
	* config/arm/arm-cores.def (License): Same.

Georg-Johann Lay <avr@gjlay.de> writes:

> This is Ping #1 for
>
> https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00747.html
>
> an addendum that adds runtime library exception to two more files
> in the ARM backend (arm-opts.h, arm-cores.def) that are included in libgcc.
>
> Ok to apply?

This is OK.  Sorry, I didn't think you were waiting for another
approval, it's basically the same as the last patch.

Ian

> Am 05/10/2014 02:51 AM, schrieb Ian Lance Taylor:
>> Georg-Johann Lay <avr@jlay.de> writes:
>>
>>> This patch adds GCC Runtime Library Exception to files that go into
>>> libgcc because libgcc2.c includes tm.h and libgcc_tm.h.
>>>
>>> Most of these files contain much code, some used by libgcc, some
>>> not. Some potential users of (lib)gcc have objections that missing RLE
>>> might "infect" their target code.
>>>
>>> Even though I know that this is actually not the case and the FSF is
>>> fine with target code linked against libgcc, it's pointless to argue
>>> in that direction. At least this is my personal experience with
>>> advocates.
>>>
>>> I am aware that there was effort for better separation of libgcc and
>>> GCC, but obviously this separation has not yet been achieved.
>>>
>>> This this ok for trunk?
>>>
>>> And is there anything special about license changes w.r.t FSF that I
>>> have to take into account?  CCed Ian so that someone from the GCC
>>> steering committee can have a look.
>>
>> I think this is unnecessary but fine.
>
> Thanks.
>
> Yes, I know it's not needed... yet it can increase acceptance of GCC.
>
> I opened a PR61152 for this so that it's clearer for why the Runtime
> Exceptions will be added:
>
> http://gcc.gnu.org/PR61152
>
> Added two files included by arm.h I missed; is it in order to apply this, too?
>
> And is it in order to apply/backport this to the 4.9 branch? From
> source perspective the changes are trivial enough.
>
> Johann
>
>
>
> 	PR libgcc/61152
> 	* config/arm/arm-opts.h (License): Add GCC Runtime Library Exception.
> 	* config/arm/arm-cores.def (License): Same.
>
>
> Index: gcc/config/arm/arm-cores.def
> ===================================================================
> --- gcc/config/arm/arm-cores.def        (revision 210321)
> +++ gcc/config/arm/arm-cores.def        (working copy)
> @@ -14,6 +14,10 @@
>     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>     General Public License for more details.
>
> +   Under Section 7 of GPL version 3, you are granted additional
> +   permissions described in the GCC Runtime Library Exception, version
> +   3.1, as published by the Free Software Foundation.
> +
>     You should have received a copy of the GNU General Public License
>     along with GCC; see the file COPYING3.  If not see
>     <http://www.gnu.org/licenses/>.  */
> Index: gcc/config/arm/arm-opts.h
> ===================================================================
> --- gcc/config/arm/arm-opts.h   (revision 210321)
> +++ gcc/config/arm/arm-opts.h   (working copy)
> @@ -13,6 +13,10 @@
>     or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
>     License for more details.
>
> +   Under Section 7 of GPL version 3, you are granted additional
> +   permissions described in the GCC Runtime Library Exception, version
> +   3.1, as published by the Free Software Foundation.
> +
>     You should have received a copy of the GNU General Public License
>     along with GCC; see the file COPYING3.  If not see
>     <http://www.gnu.org/licenses/>.  */